pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Andres Freund <andres@anarazel.de>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Andrew Dunstan <andrew@dunslane.net>
Cc: pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Check that we have a working tar before trying to use it
Date: Wed, 8 Dec 2021 19:08:56 -0800
Message-ID: <20211209030856.ibxewzpc5ph7ckkp@alap3.anarazel.de> (raw)
In-Reply-To: <20211209024604.dpmudj4ax2hoi7cx@alap3.anarazel.de>
References: <E1muynv-0006GS-R4@gemulon.postgresql.org>
	<3655283.1638977975@sss.pgh.pa.us>
	<2e118a11-6936-21ec-6782-e9dbb20972c2@dunslane.net>
	<3657697.1638980149@sss.pgh.pa.us>
	<b179201e-8451-6a5e-e9be-9c755a13be7f@dunslane.net>
	<3660797.1638983124@sss.pgh.pa.us>
	<b6782dc3-a7b0-ed56-175f-f8f54cb08d67@dunslane.net>
	<20211209021604.bv5tfr23ymh4u7x4@alap3.anarazel.de>
	<3707204.1639016334@sss.pgh.pa.us>
	<20211209024604.dpmudj4ax2hoi7cx@alap3.anarazel.de>

Hi,

On 2021-12-08 18:46:04 -0800, Andres Freund wrote:
> On 2021-12-08 21:18:54 -0500, Tom Lane wrote:
> > Andres Freund <andres@anarazel.de> writes:
> > > Git appears to install itself in front of c:\windows\system32 in PATH (which
> > > contains the system tar). Which I think means that after edc2332550 this will
> > > have to be manually addressed by most people running tests on windows
> > > manually? That doesn't seem great :(
> > 
> > Can we make the default be the system tar (ie a full path, not
> > just "tar")?  I have no idea if that's a stable thing on Windows ...
> 
> It's not stable, but afaict all the "instability" can be handled by relying on
> a system-set environment variable... Referencing it as
> $ENV{SYSTEMROOT}/system32/tar.exe ought to work? I'll test that approach via
> CI, but of course that won't verify that it works in all kinds of odd
> installations.

That worked: https://cirrus-ci.com/task/6302355785252864
https://github.com/anarazel/postgres/commit/49cf19f160080353da391f177a7d8c28218023bb

[03:01:52.451] t/010_pg_basebackup.pl ... ok
[03:02:09.737] t/020_pg_receivewal.pl ... ok
[03:02:11.837] t/030_pg_recvlogical.pl .. ok
[03:02:11.848] Result: PASS



view thread (25+ messages)  latest in thread

Message-ID: <20211209030856.ibxewzpc5ph7ckkp@alap3.anarazel.de>
Permalink:  ../20211209030856.ibxewzpc5ph7ckkp@alap3.anarazel.de/
Also on:    postgresql.org/message-id/20211209030856.ibxewzpc5ph7ckkp@alap3.anarazel.de

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: andres@anarazel.de, tgl@sss.pgh.pa.us, andrew@dunslane.net, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: Check that we have a working tar before trying to use it
  In-Reply-To: <20211209030856.ibxewzpc5ph7ckkp@alap3.anarazel.de>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox