pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
pgsql: Fix some trailing whitespace in documentation files
9+ messages / 5 participants
[nested] [flat]

Commits from this thread:
  2022-04-20 836af9756b  Remove trailing whitespace from *.sgml files.
* pgsql: Fix some trailing whitespace in documentation files
@ 2021-04-22 20:56 Peter Eisentraut <peter@eisentraut.org>
  0 siblings, 0 replies; 9+ messages in thread

From: Peter Eisentraut @ 2021-04-22 20:56 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Fix some trailing whitespace in documentation files

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/197d33ccbe888fc84ae4e49bb241e88ea3c81f15

Modified Files
--------------
doc/src/sgml/fdwhandler.sgml          | 4 ++--
doc/src/sgml/installation.sgml        | 2 +-
doc/src/sgml/logical-replication.sgml | 2 +-
doc/src/sgml/logicaldecoding.sgml     | 4 ++--
doc/src/sgml/ref/pgupgrade.sgml       | 2 +-
doc/src/sgml/ref/psql-ref.sgml        | 2 +-
doc/src/sgml/ref/reindex.sgml         | 2 +-
doc/src/sgml/ref/vacuum.sgml          | 2 +-
doc/src/sgml/wal.sgml                 | 4 ++--
9 files changed, 12 insertions(+), 12 deletions(-)



^ permalink  raw  reply  [nested|flat] 9+ messages in thread

* pgsql: Fix some trailing whitespace in documentation files
@ 2022-04-16 07:05 Peter Eisentraut <peter@eisentraut.org>
  2022-04-16 20:26 ` Re: pgsql: Fix some trailing whitespace in documentation files Tom Lane <tgl@sss.pgh.pa.us>
  0 siblings, 1 reply; 9+ messages in thread

From: Peter Eisentraut @ 2022-04-16 07:05 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Fix some trailing whitespace in documentation files

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/5a892c9b154f513a42c4a42cdfdae524ce33c86a

Modified Files
--------------
doc/src/sgml/adminpack.sgml         |  2 +-
doc/src/sgml/custom-rmgr.sgml       |  4 ++--
doc/src/sgml/func.sgml              | 20 ++++++++++----------
doc/src/sgml/high-availability.sgml |  2 +-
doc/src/sgml/pgwalinspect.sgml      |  2 +-
doc/src/sgml/ref/pgbench.sgml       |  2 +-
doc/src/sgml/runtime.sgml           |  2 +-
7 files changed, 17 insertions(+), 17 deletions(-)



^ permalink  raw  reply  [nested|flat] 9+ messages in thread

* Re: pgsql: Fix some trailing whitespace in documentation files
  2022-04-16 07:05 pgsql: Fix some trailing whitespace in documentation files Peter Eisentraut <peter@eisentraut.org>
@ 2022-04-16 20:26 ` Tom Lane <tgl@sss.pgh.pa.us>
  2022-04-19 09:37   ` Re: pgsql: Fix some trailing whitespace in documentation files Daniel Gustafsson <daniel@yesql.se>
  2022-04-19 13:39   ` Re: pgsql: Fix some trailing whitespace in documentation files Peter Eisentraut <peter.eisentraut@enterprisedb.com>
  0 siblings, 2 replies; 9+ messages in thread

From: Tom Lane @ 2022-04-16 20:26 UTC (permalink / raw)
  To: Peter Eisentraut <peter@eisentraut.org>; +Cc: pgsql-committers@lists.postgresql.org

Peter Eisentraut <peter@eisentraut.org> writes:
> Fix some trailing whitespace in documentation files

Hmm ... by my count there are still 245 lines with trailing spaces
in the *.sgml files.  (Most but not all are from copied-n-pasted
psql output.)

I'm not quite sure what's the point of retail fixes.  I could
get behind removing *all* these occurrences, and then adjusting
.gitattributes so that git bleats about introducing new ones.
Other folks might find that a little too obsessive-compulsive,
though.

			regards, tom lane





^ permalink  raw  reply  [nested|flat] 9+ messages in thread

* Re: pgsql: Fix some trailing whitespace in documentation files
  2022-04-16 07:05 pgsql: Fix some trailing whitespace in documentation files Peter Eisentraut <peter@eisentraut.org>
  2022-04-16 20:26 ` Re: pgsql: Fix some trailing whitespace in documentation files Tom Lane <tgl@sss.pgh.pa.us>
@ 2022-04-19 09:37   ` Daniel Gustafsson <daniel@yesql.se>
  1 sibling, 0 replies; 9+ messages in thread

From: Daniel Gustafsson @ 2022-04-19 09:37 UTC (permalink / raw)
  To: Tom Lane <tgl@sss.pgh.pa.us>; +Cc: Peter Eisentraut <peter@eisentraut.org>; pgsql-committers@lists.postgresql.org

> On 16 Apr 2022, at 22:26, Tom Lane <tgl@sss.pgh.pa.us> wrote:

> I'm not quite sure what's the point of retail fixes.  I could
> get behind removing *all* these occurrences, and then adjusting
> .gitattributes so that git bleats about introducing new ones.
> Other folks might find that a little too obsessive-compulsive,
> though.

If we don't want them in the docs in the first place (which I agree that we
don't), I would prefer them highlighted sooner rather than later.

--
Daniel Gustafsson		https://vmware.com/






^ permalink  raw  reply  [nested|flat] 9+ messages in thread

* Re: pgsql: Fix some trailing whitespace in documentation files
  2022-04-16 07:05 pgsql: Fix some trailing whitespace in documentation files Peter Eisentraut <peter@eisentraut.org>
  2022-04-16 20:26 ` Re: pgsql: Fix some trailing whitespace in documentation files Tom Lane <tgl@sss.pgh.pa.us>
@ 2022-04-19 13:39   ` Peter Eisentraut <peter.eisentraut@enterprisedb.com>
  2022-04-19 14:24     ` Re: pgsql: Fix some trailing whitespace in documentation files Tom Lane <tgl@sss.pgh.pa.us>
  1 sibling, 1 reply; 9+ messages in thread

From: Peter Eisentraut @ 2022-04-19 13:39 UTC (permalink / raw)
  To: Tom Lane <tgl@sss.pgh.pa.us>; +Cc: pgsql-committers@lists.postgresql.org

On 16.04.22 22:26, Tom Lane wrote:
> Hmm ... by my count there are still 245 lines with trailing spaces
> in the *.sgml files.  (Most but not all are from copied-n-pasted
> psql output.)
> 
> I'm not quite sure what's the point of retail fixes.  I could
> get behind removing*all*  these occurrences, and then adjusting
> .gitattributes so that git bleats about introducing new ones.
> Other folks might find that a little too obsessive-compulsive,
> though.

If someone wants to set that up, I'm not opposed.  In the meantime, I'm 
content to clean up stray whitespace once in a while.  I don't want to 
not do that, because otherwise too much junk will accumulate.






^ permalink  raw  reply  [nested|flat] 9+ messages in thread

* Re: pgsql: Fix some trailing whitespace in documentation files
  2022-04-16 07:05 pgsql: Fix some trailing whitespace in documentation files Peter Eisentraut <peter@eisentraut.org>
  2022-04-16 20:26 ` Re: pgsql: Fix some trailing whitespace in documentation files Tom Lane <tgl@sss.pgh.pa.us>
  2022-04-19 13:39   ` Re: pgsql: Fix some trailing whitespace in documentation files Peter Eisentraut <peter.eisentraut@enterprisedb.com>
@ 2022-04-19 14:24     ` Tom Lane <tgl@sss.pgh.pa.us>
  2022-04-19 18:57       ` Re: pgsql: Fix some trailing whitespace in documentation files Daniel Gustafsson <daniel@yesql.se>
  0 siblings, 1 reply; 9+ messages in thread

From: Tom Lane @ 2022-04-19 14:24 UTC (permalink / raw)
  To: Peter Eisentraut <peter.eisentraut@enterprisedb.com>; +Cc: pgsql-committers@lists.postgresql.org

Peter Eisentraut <peter.eisentraut@enterprisedb.com> writes:
> On 16.04.22 22:26, Tom Lane wrote:
>> I'm not quite sure what's the point of retail fixes.  I could
>> get behind removing*all*  these occurrences, and then adjusting
>> .gitattributes so that git bleats about introducing new ones.
>> Other folks might find that a little too obsessive-compulsive,
>> though.

> If someone wants to set that up, I'm not opposed.  In the meantime, I'm 
> content to clean up stray whitespace once in a while.  I don't want to 
> not do that, because otherwise too much junk will accumulate.

It's bothered the neatnik in me for a long time, so I'm happy to
make it happen if there are not objections.

			regards, tom lane





^ permalink  raw  reply  [nested|flat] 9+ messages in thread

* Re: pgsql: Fix some trailing whitespace in documentation files
  2022-04-16 07:05 pgsql: Fix some trailing whitespace in documentation files Peter Eisentraut <peter@eisentraut.org>
  2022-04-16 20:26 ` Re: pgsql: Fix some trailing whitespace in documentation files Tom Lane <tgl@sss.pgh.pa.us>
  2022-04-19 13:39   ` Re: pgsql: Fix some trailing whitespace in documentation files Peter Eisentraut <peter.eisentraut@enterprisedb.com>
  2022-04-19 14:24     ` Re: pgsql: Fix some trailing whitespace in documentation files Tom Lane <tgl@sss.pgh.pa.us>
@ 2022-04-19 18:57       ` Daniel Gustafsson <daniel@yesql.se>
  2022-04-19 19:09         ` Re: pgsql: Fix some trailing whitespace in documentation files Bruce Momjian <bruce@momjian.us>
  0 siblings, 1 reply; 9+ messages in thread

From: Daniel Gustafsson @ 2022-04-19 18:57 UTC (permalink / raw)
  To: Tom Lane <tgl@sss.pgh.pa.us>; +Cc: Peter Eisentraut <peter.eisentraut@enterprisedb.com>; pgsql-committers@lists.postgresql.org

> On 19 Apr 2022, at 16:24, Tom Lane <tgl@sss.pgh.pa.us> wrote:

> It's bothered the neatnik in me for a long time, so I'm happy to
> make it happen if there are not objections.

Mildly on-topic: Has the topic of a pgindent like process for docs been
discussed at some point? The archives didn't turn up anything for me.

--
Daniel Gustafsson		https://vmware.com/






^ permalink  raw  reply  [nested|flat] 9+ messages in thread

* Re: pgsql: Fix some trailing whitespace in documentation files
  2022-04-16 07:05 pgsql: Fix some trailing whitespace in documentation files Peter Eisentraut <peter@eisentraut.org>
  2022-04-16 20:26 ` Re: pgsql: Fix some trailing whitespace in documentation files Tom Lane <tgl@sss.pgh.pa.us>
  2022-04-19 13:39   ` Re: pgsql: Fix some trailing whitespace in documentation files Peter Eisentraut <peter.eisentraut@enterprisedb.com>
  2022-04-19 14:24     ` Re: pgsql: Fix some trailing whitespace in documentation files Tom Lane <tgl@sss.pgh.pa.us>
  2022-04-19 18:57       ` Re: pgsql: Fix some trailing whitespace in documentation files Daniel Gustafsson <daniel@yesql.se>
@ 2022-04-19 19:09         ` Bruce Momjian <bruce@momjian.us>
  2022-04-20 15:18           ` Re: pgsql: Fix some trailing whitespace in documentation files Tom Lane <tgl@sss.pgh.pa.us>
  0 siblings, 1 reply; 9+ messages in thread

From: Bruce Momjian @ 2022-04-19 19:09 UTC (permalink / raw)
  To: Daniel Gustafsson <daniel@yesql.se>; +Cc: Tom Lane <tgl@sss.pgh.pa.us>; Peter Eisentraut <peter.eisentraut@enterprisedb.com>; pgsql-committers@lists.postgresql.org

On Tue, Apr 19, 2022 at 08:57:23PM +0200, Daniel Gustafsson wrote:
> > On 19 Apr 2022, at 16:24, Tom Lane <tgl@sss.pgh.pa.us> wrote:
> 
> > It's bothered the neatnik in me for a long time, so I'm happy to
> > make it happen if there are not objections.
> 
> Mildly on-topic: Has the topic of a pgindent like process for docs been
> discussed at some point? The archives didn't turn up anything for me.

I don't remember any discussion of that.  We have 'make check-tabs' for
SGML files, but that's about it.

-- 
  Bruce Momjian  <bruce@momjian.us>        https://momjian.us
  EDB                                      https://enterprisedb.com

  Indecision is a decision.  Inaction is an action.  Mark Batterson






^ permalink  raw  reply  [nested|flat] 9+ messages in thread

* Re: pgsql: Fix some trailing whitespace in documentation files
  2022-04-16 07:05 pgsql: Fix some trailing whitespace in documentation files Peter Eisentraut <peter@eisentraut.org>
  2022-04-16 20:26 ` Re: pgsql: Fix some trailing whitespace in documentation files Tom Lane <tgl@sss.pgh.pa.us>
  2022-04-19 13:39   ` Re: pgsql: Fix some trailing whitespace in documentation files Peter Eisentraut <peter.eisentraut@enterprisedb.com>
  2022-04-19 14:24     ` Re: pgsql: Fix some trailing whitespace in documentation files Tom Lane <tgl@sss.pgh.pa.us>
  2022-04-19 18:57       ` Re: pgsql: Fix some trailing whitespace in documentation files Daniel Gustafsson <daniel@yesql.se>
  2022-04-19 19:09         ` Re: pgsql: Fix some trailing whitespace in documentation files Bruce Momjian <bruce@momjian.us>
@ 2022-04-20 15:18           ` Tom Lane <tgl@sss.pgh.pa.us>
  0 siblings, 0 replies; 9+ messages in thread

From: Tom Lane @ 2022-04-20 15:18 UTC (permalink / raw)
  To: Bruce Momjian <bruce@momjian.us>; +Cc: Daniel Gustafsson <daniel@yesql.se>; Peter Eisentraut <peter.eisentraut@enterprisedb.com>; pgsql-committers@lists.postgresql.org

Bruce Momjian <bruce@momjian.us> writes:
> On Tue, Apr 19, 2022 at 08:57:23PM +0200, Daniel Gustafsson wrote:
>> Mildly on-topic: Has the topic of a pgindent like process for docs been
>> discussed at some point? The archives didn't turn up anything for me.

> I don't remember any discussion of that.  We have 'make check-tabs' for
> SGML files, but that's about it.

I've pushed a patch to remove the remaining trailing whitespace.

I thought about adjusting 'make check-tabs' to know about that rule,
but on the whole I'm inclined to remove it instead.  The modern
technology for this is "git diff --check" and variants of that,
and I'm not sure why we should maintain a less-flexible alternative.
(It'd be one less headache for the meson conversion, too.)

			regards, tom lane





^ permalink  raw  reply  [nested|flat] 9+ messages in thread


end of thread, other threads:[~2022-04-20 15:18 UTC | newest]

Thread overview: 9+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2021-04-22 20:56 pgsql: Fix some trailing whitespace in documentation files Peter Eisentraut <peter@eisentraut.org>
2022-04-16 07:05 pgsql: Fix some trailing whitespace in documentation files Peter Eisentraut <peter@eisentraut.org>
2022-04-16 20:26 ` Tom Lane <tgl@sss.pgh.pa.us>
2022-04-19 09:37   ` Daniel Gustafsson <daniel@yesql.se>
2022-04-19 13:39   ` Peter Eisentraut <peter.eisentraut@enterprisedb.com>
2022-04-19 14:24     ` Tom Lane <tgl@sss.pgh.pa.us>
2022-04-19 18:57       ` Daniel Gustafsson <daniel@yesql.se>
2022-04-19 19:09         ` Bruce Momjian <bruce@momjian.us>
2022-04-20 15:18           ` Tom Lane <tgl@sss.pgh.pa.us>

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox