From: Tom Lane <tgl@sss.pgh.pa.us>
To: Bruce Momjian <bruce@momjian.us>
Cc: Daniel Gustafsson <daniel@yesql.se>
Cc: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
Cc: pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Fix some trailing whitespace in documentation files
Date: Wed, 20 Apr 2022 11:18:55 -0400
Message-ID: <2830044.1650467935@sss.pgh.pa.us> (raw)
In-Reply-To: <Yl8I6vBcv/T2mIOE@momjian.us>
References: <E1nfcV1-000kOR-E5@gemulon.postgresql.org>
<2021248.1650140817@sss.pgh.pa.us>
<90abc132-ab5a-cbef-b330-8d58c24e4c6c@enterprisedb.com>
<2548443.1650378244@sss.pgh.pa.us>
<1A5D1665-86ED-4A96-A552-C7207CD5CF90@yesql.se>
<Yl8I6vBcv/T2mIOE@momjian.us>
Bruce Momjian <bruce@momjian.us> writes:
> On Tue, Apr 19, 2022 at 08:57:23PM +0200, Daniel Gustafsson wrote:
>> Mildly on-topic: Has the topic of a pgindent like process for docs been
>> discussed at some point? The archives didn't turn up anything for me.
> I don't remember any discussion of that. We have 'make check-tabs' for
> SGML files, but that's about it.
I've pushed a patch to remove the remaining trailing whitespace.
I thought about adjusting 'make check-tabs' to know about that rule,
but on the whole I'm inclined to remove it instead. The modern
technology for this is "git diff --check" and variants of that,
and I'm not sure why we should maintain a less-flexible alternative.
(It'd be one less headache for the meson conversion, too.)
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients from your mail client; the link fills in
the headers below: reply via email
Some clients, webmail especially, drop In-Reply-To and References from
a link, and the reply then starts a new thread: use the mbox below.
To: pgsql-committers@postgresql.org
Cc: tgl@sss.pgh.pa.us, bruce@momjian.us, daniel@yesql.se, peter.eisentraut@enterprisedb.com
Subject: Re: pgsql: Fix some trailing whitespace in documentation files
In-Reply-To: <2830044.1650467935@sss.pgh.pa.us>
References: <E1nfcV1-000kOR-E5@gemulon.postgresql.org> <2021248.1650140817@sss.pgh.pa.us> <90abc132-ab5a-cbef-b330-8d58c24e4c6c@enterprisedb.com> <2548443.1650378244@sss.pgh.pa.us> <1A5D1665-86ED-4A96-A552-C7207CD5CF90@yesql.se> <Yl8I6vBcv/T2mIOE@momjian.us> <2830044.1650467935@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox