From: Andres Freund <andres@anarazel.de>
To: Thomas Munro <thomas.munro@gmail.com>
Cc: Michael Paquier <michael@paquier.xyz>
Cc: Thomas Munro <tmunro@postgresql.org>
Cc: pgsql-committers <pgsql-committers@lists.postgresql.org>
Subject: Re: pgsql: Test replay of regression tests, attempt II.
Date: Mon, 17 Jan 2022 12:48:14 -0800
Message-ID: <20220117204814.5w2kjxclodxjclwn@alap3.anarazel.de> (raw)
In-Reply-To: <CA+hUKGLPPyRfB+sGURj+LKxgeEGEwZtUT=W=H+cbDY43YqpJug@mail.gmail.com>
References: <E1n9Io8-0007At-FQ@gemulon.postgresql.org>
<YeUUiruW+mqNNGIG@paquier.xyz>
<CA+hUKGLPPyRfB+sGURj+LKxgeEGEwZtUT=W=H+cbDY43YqpJug@mail.gmail.com>
Hi,
On 2022-01-18 07:47:48 +1300, Thomas Munro wrote:
> > No idea what's going on here, but I guess that we'd better show up the
> > contents of regression.diffs in the TAP logs if it exists.
>
> Hmm. Yeah.
It already is in the regress_log_*, but I agree, it'd be good to add it to the
normal output in the failure case.
https://api.cirrus-ci.com/v1/artifact/task/6460573058596864/tap/src/test/recovery/tmp_check/log/regr...
I think system_or_bail() might be the wrong tool here. If I understand
Test::More's BAIL_OUT() correctly [1], it'll prevent other tests from running as
well. Which doesn't seem quite right for a failure like this?
Kinda seems like nearly all of our uses of system_or_bail() are bad?
Greetings,
Andres Freund
[1]: https://perldoc.perl.org/Test::More#Test-control
"Indicates to the harness that things are going so badly all testing
should terminate. This includes the running of any additional test scripts."
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients from your mail client; the link fills in
the headers below: reply via email
Some clients, webmail especially, drop In-Reply-To and References from
a link, and the reply then starts a new thread: use the mbox below.
To: pgsql-committers@postgresql.org
Cc: andres@anarazel.de, thomas.munro@gmail.com, michael@paquier.xyz, tmunro@postgresql.org
Subject: Re: pgsql: Test replay of regression tests, attempt II.
In-Reply-To: <20220117204814.5w2kjxclodxjclwn@alap3.anarazel.de>
References: <E1n9Io8-0007At-FQ@gemulon.postgresql.org> <YeUUiruW+mqNNGIG@paquier.xyz> <CA+hUKGLPPyRfB+sGURj+LKxgeEGEwZtUT=W=H+cbDY43YqpJug@mail.gmail.com> <20220117204814.5w2kjxclodxjclwn@alap3.anarazel.de>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox