From: Andres Freund <andres@anarazel.de>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Thomas Munro <thomas.munro@gmail.com>
Cc: Michael Paquier <michael@paquier.xyz>
Cc: Thomas Munro <tmunro@postgresql.org>
Cc: pgsql-committers <pgsql-committers@lists.postgresql.org>
Subject: Re: pgsql: Test replay of regression tests, attempt II.
Date: Tue, 18 Jan 2022 15:08:38 -0800
Message-ID: <20220118230838.amvazn2ig4cf56oy@alap3.anarazel.de> (raw)
In-Reply-To: <415981.1642544346@sss.pgh.pa.us>
References: <E1n9Io8-0007At-FQ@gemulon.postgresql.org>
<YeUUiruW+mqNNGIG@paquier.xyz>
<20220117203746.oj43254j5jurbneu@alap3.anarazel.de>
<CA+hUKGLT2UL5_JhmBzUgkdyKfc=5J-gJSQJLysMs4rqLUKLAzw@mail.gmail.com>
<CA+hUKGJDrokTTT3fAEESHiW5TmwxkkJGqe8bR-VFjpg4+hK+fQ@mail.gmail.com>
<374643.1642536944@sss.pgh.pa.us>
<20220118204012.qpfas4fmvc55g4ei@alap3.anarazel.de>
<415981.1642544346@sss.pgh.pa.us>
Hi,
On 2022-01-18 17:19:06 -0500, Tom Lane wrote:
> Andres Freund <andres@anarazel.de> writes:
> > That's an extremely small shared_buffers for running the regression tests, it'd not
> > be surprising if that provoked problems we don't otherwise see. Perhaps VACUUM
> > ends up skipping over a page because of page contention?
>
> Hmm, good thought. I tried running the test with even smaller
> shared_buffers, but could not make the reloptions test fall over for
> me. But this theory implies a strong timing dependency, so it might
> still only happen on particular machines. (If anyone else tries it:
> below about 400kB, other tests start failing with "no free unpinned
> buffers" and the like.)
I ran the test in a loop for 200+ times now, without reproducing the
problem. Rorqual runs on a shared machine though, so it's quite possible that
IO will be slower, and thus triggering the issue.
I was wondering whether we could use VACUUM VERBOSE for that specific VACUUM -
that'd show information about the number of pages with tuples etc. But I don't
currently see a way of that causing the regression tests to fail.
Even if I set client_min_messages=error, the messages still get sent to the
client, because elevel == INFO is special cased in
should_output_to_client(). And I don't see a way of redirecting the output of
common.c:NoticeProcessor() in psql either.
Greetings,
Andres Freund
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients from your mail client; the link fills in
the headers below: reply via email
Some clients, webmail especially, drop In-Reply-To and References from
a link, and the reply then starts a new thread: use the mbox below.
To: pgsql-committers@postgresql.org
Cc: andres@anarazel.de, tgl@sss.pgh.pa.us, thomas.munro@gmail.com, michael@paquier.xyz, tmunro@postgresql.org
Subject: Re: pgsql: Test replay of regression tests, attempt II.
In-Reply-To: <20220118230838.amvazn2ig4cf56oy@alap3.anarazel.de>
References: <E1n9Io8-0007At-FQ@gemulon.postgresql.org> <YeUUiruW+mqNNGIG@paquier.xyz> <20220117203746.oj43254j5jurbneu@alap3.anarazel.de> <CA+hUKGLT2UL5_JhmBzUgkdyKfc=5J-gJSQJLysMs4rqLUKLAzw@mail.gmail.com> <CA+hUKGJDrokTTT3fAEESHiW5TmwxkkJGqe8bR-VFjpg4+hK+fQ@mail.gmail.com> <374643.1642536944@sss.pgh.pa.us> <20220118204012.qpfas4fmvc55g4ei@alap3.anarazel.de> <415981.1642544346@sss.pgh.pa.us> <20220118230838.amvazn2ig4cf56oy@alap3.anarazel.de>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox