pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Andres Freund <andres@anarazel.de>
To: Etsuro Fujita <efujita@postgresql.org>
Cc: pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Further fix for EvalPlanQual with mix of local and foreign parti
Date: Thu, 3 Feb 2022 10:36:55 -0800
Message-ID: <20220203183655.ralgkh54sdcgysmn@alap3.anarazel.de> (raw)
In-Reply-To: <E1nFVWE-0001jB-9n@gemulon.postgresql.org>
References: <E1nFVWE-0001jB-9n@gemulon.postgresql.org>

Hi,

On 2022-02-03 06:22:58 +0000, Etsuro Fujita wrote:
> Further fix for EvalPlanQual with mix of local and foreign partitions.

My compiler (as well as cfbot) now complains that there is an unused variable,
when building without assertions:

/home/andres/src/postgresql/src/backend/executor/nodeForeignscan.c: In function ‘ForeignNext’:
/home/andres/src/postgresql/src/backend/executor/nodeForeignscan.c:47:21: warning: unused variable ‘estate’ [-Wunused-variable]
   47 |         EState     *estate = node->ss.ps.state;
      |                     ^~~~~~

Seems best to just use node->ss.ps.state instead of the local estate variable?
Rather than using the noisier PG_USED_FOR_ASSERTS_ONLY.

I'll make it so, unless you want to?

Greetings,

Andres Freund





view thread (5+ messages)  latest in thread

Message-ID: <20220203183655.ralgkh54sdcgysmn@alap3.anarazel.de>
Permalink:  ../20220203183655.ralgkh54sdcgysmn@alap3.anarazel.de/
Also on:    postgresql.org/message-id/20220203183655.ralgkh54sdcgysmn@alap3.anarazel.de

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: andres@anarazel.de, efujita@postgresql.org
  Subject: Re: pgsql: Further fix for EvalPlanQual with mix of local and foreign parti
  In-Reply-To: <20220203183655.ralgkh54sdcgysmn@alap3.anarazel.de>
  References: <E1nFVWE-0001jB-9n@gemulon.postgresql.org> <20220203183655.ralgkh54sdcgysmn@alap3.anarazel.de>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox