From: Andres Freund <andres@anarazel.de>
To: Tom Lane <tgl@sss.pgh.pa.us>
To: Thomas Munro <thomas.munro@gmail.com>
Cc: pgsql-committers@lists.postgresql.org, Kyotaro HORIGUCHI <horiguchi.kyotaro@lab.ntt.co.jp>
Subject: Re: pgsql: dshash: Add sequential scan support.
Date: Thu, 10 Mar 2022 17:27:12 -0800
Message-ID: <20220311012712.botrpsikaufzteyt@alap3.anarazel.de> (raw)
In-Reply-To: <758107.1646960996@sss.pgh.pa.us>
References: <E1nSTgB-000BxB-4B@gemulon.postgresql.org>
<758107.1646960996@sss.pgh.pa.us>
Hi,
On 2022-03-10 20:09:56 -0500, Tom Lane wrote:
> Andres Freund <andres@anarazel.de> writes:
> > dshash: Add sequential scan support.
> > Add ability to scan all entries sequentially to dshash. The interface is
> > similar but a bit different both from that of dynahash and simple dshash
> > search functions. The most significant differences is that dshash's interfac
> > always needs a call to dshash_seq_term when scan ends.
>
> Umm ... what about error recovery? Or have you just cemented the
> proposition that long-lived dshashes are unsafe?
I don't think this commit made it worse. dshash_seq_term() releases an lwlock
(which will be released in case of an error) and unsets
hash_table->find_[exclusively_]locked. The latter weren't introduced by this
patch, and are also set by dshash_find().
I agree that ->find_[exclusively_]locked are problematic from an error
recovery perspective.
It's per-backend state at least and just used for assertions. We could remove
it. Or stop checking it in places where it could be set wrongly: dshash_find()
and dshash_detach() couldn't check anymore, but the rest of the assertions
would still be valid afaics?
Greetings,
Andres Freund
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients from your mail client; the link fills in
the headers below: reply via email
Some clients, webmail especially, drop In-Reply-To and References from
a link, and the reply then starts a new thread: use the mbox below.
To: pgsql-committers@postgresql.org
Cc: andres@anarazel.de, tgl@sss.pgh.pa.us, thomas.munro@gmail.com, horiguchi.kyotaro@lab.ntt.co.jp
Subject: Re: pgsql: dshash: Add sequential scan support.
In-Reply-To: <20220311012712.botrpsikaufzteyt@alap3.anarazel.de>
References: <E1nSTgB-000BxB-4B@gemulon.postgresql.org> <758107.1646960996@sss.pgh.pa.us> <20220311012712.botrpsikaufzteyt@alap3.anarazel.de>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox