pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andres Freund <andres@anarazel.de>
Cc: pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: dshash: Add sequential scan support.
Date: Thu, 10 Mar 2022 20:09:56 -0500
Message-ID: <758107.1646960996@sss.pgh.pa.us> (raw)
In-Reply-To: <E1nSTgB-000BxB-4B@gemulon.postgresql.org>
References: <E1nSTgB-000BxB-4B@gemulon.postgresql.org>

Andres Freund <andres@anarazel.de> writes:
> dshash: Add sequential scan support.
> Add ability to scan all entries sequentially to dshash. The interface is
> similar but a bit different both from that of dynahash and simple dshash
> search functions. The most significant differences is that dshash's interfac
> always needs a call to dshash_seq_term when scan ends.

Umm ... what about error recovery?  Or have you just cemented the
proposition that long-lived dshashes are unsafe?

			regards, tom lane





view thread (11+ messages)  latest in thread

Message-ID: <758107.1646960996@sss.pgh.pa.us>
Permalink:  ../758107.1646960996@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/758107.1646960996@sss.pgh.pa.us

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: tgl@sss.pgh.pa.us, andres@anarazel.de
  Subject: Re: pgsql: dshash: Add sequential scan support.
  In-Reply-To: <758107.1646960996@sss.pgh.pa.us>
  References: <E1nSTgB-000BxB-4B@gemulon.postgresql.org> <758107.1646960996@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox