pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Alvaro Herrera <alvherre@alvh.no-ip.org>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Enforce foreign key correctly during cross-partition updates
Date: Sun, 20 Mar 2022 22:26:33 +0100
Message-ID: <202203202126.5susqfvj43q5@alvherre.pgsql> (raw)
In-Reply-To: <1596411.1647808192@sss.pgh.pa.us>

On 2022-Mar-20, Tom Lane wrote:

> ==2663594== Conditional jump or move depends on uninitialised value(s)
> ==2663594==    at 0x421526: ExecUpdateAct (nodeModifyTable.c:1855)

> It reproduces easily for me under valgrind.  I guess
> ExecCrossPartitionUpdate must be failing to set
> inserted_tuple or insert_destrel.

Yeah, I was trying to reproduce it -- but it doesn't for me.  Strange.
Anyway, I think you're right: insert_destrel is used in the test when
ExecCrossPartitionUpdate returns true, and clearly it can do that and
not set insert_destrel.

-- 
Álvaro Herrera              Valdivia, Chile  —  https://www.EnterpriseDB.com/
"La grandeza es una experiencia transitoria.  Nunca es consistente.
Depende en gran parte de la imaginación humana creadora de mitos"
(Irulan)





view thread (3+ messages)

Message-ID: <202203202126.5susqfvj43q5@alvherre.pgsql>
Permalink:  ../202203202126.5susqfvj43q5@alvherre.pgsql/
Also on:    postgresql.org/message-id/202203202126.5susqfvj43q5@alvherre.pgsql

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: alvherre@alvh.no-ip.org, tgl@sss.pgh.pa.us
  Subject: Re: pgsql: Enforce foreign key correctly during cross-partition updates
  In-Reply-To: <202203202126.5susqfvj43q5@alvherre.pgsql>
  References: <1596411.1647808192@sss.pgh.pa.us> <202203202126.5susqfvj43q5@alvherre.pgsql>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox