pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Alvaro Herrera <alvherre@alvh.no-ip.org>
To: Andrew Dunstan <andrew@dunslane.net>
Cc: Andres Freund <andres@anarazel.de>
Cc: pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Common SQL/JSON clauses
Date: Wed, 23 Mar 2022 10:47:26 +0100
Message-ID: <202203230947.rz7ll75qxp2f@alvherre.pgsql> (raw)
In-Reply-To: <9fee834f-ddd9-2adb-0d6f-4ad5af92c12b@dunslane.net>

On 2022-Mar-22, Andrew Dunstan wrote:

> Tomorrow, with the SQL/JSON constructors patch should resolve it. So
> roughly 24 hours. It's not his fault but this happened because Alvaro
> asked me to stagger the commits.

Ouch, yeah.  This kind of problem can be observed by using something
like

git rebase -i origin/master -x "make install"

this will generate a rebase "todo list" that includes a "make install"
step after each individual commit, so you can verify that each commit is
warning-clean.

(By default there is no pause after each commit if there is a failure;
my strategy for dealing with that is to change each patch in the
rebase-todo-list from "pick" to "edit", so I can fix any problems, add
them to the commit, then continue the rebase.)

-- 
Álvaro Herrera         PostgreSQL Developer  —  https://www.EnterpriseDB.com/
"En las profundidades de nuestro inconsciente hay una obsesiva necesidad
de un universo lógico y coherente. Pero el universo real se halla siempre
un paso más allá de la lógica" (Irulan)





view thread (7+ messages)  latest in thread

Message-ID: <202203230947.rz7ll75qxp2f@alvherre.pgsql>
Permalink:  ../202203230947.rz7ll75qxp2f@alvherre.pgsql/
Also on:    postgresql.org/message-id/202203230947.rz7ll75qxp2f@alvherre.pgsql

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: alvherre@alvh.no-ip.org, andrew@dunslane.net, andres@anarazel.de
  Subject: Re: pgsql: Common SQL/JSON clauses
  In-Reply-To: <202203230947.rz7ll75qxp2f@alvherre.pgsql>
  References: <9fee834f-ddd9-2adb-0d6f-4ad5af92c12b@dunslane.net> <202203230947.rz7ll75qxp2f@alvherre.pgsql>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox