From: Andres Freund <andres@anarazel.de>
To: Robert Haas <robertmhaas@gmail.com>
Cc: pgsql-committers <pgsql-committers@lists.postgresql.org>
Subject: Re: pgsql: Unbreak the build.
Date: Wed, 23 Mar 2022 08:49:48 -0700
Message-ID: <20220323154948.izypvuod5ddgyj46@alap3.anarazel.de> (raw)
In-Reply-To: <CA+TgmoandqPXmJt5JGq3zhNg4geUv0ruj9C8P+gRY3+z50CPww@mail.gmail.com>
References: <E1nX1uH-0011tI-8h@gemulon.postgresql.org>
<C6A7643A-582B-47F7-A03D-01736BC0349B@anarazel.de>
<CA+TgmoandqPXmJt5JGq3zhNg4geUv0ruj9C8P+gRY3+z50CPww@mail.gmail.com>
Hi,
On 2022-03-23 11:38:39 -0400, Robert Haas wrote:
> On Wed, Mar 23, 2022 at 10:46 AM Andres Freund <andres@anarazel.de> wrote:
> > There's new warnings that sound reasonable introduced in the prior commit that didn't get removed in this one:
> >
> > https://cirrus-ci.com/task/5259487073271808?logs=mingw_cross_warning#L392
>
> That link takes me to a screen that shows no warnings.
Hm, apparently copied the link with slightly off line numbers. Odd.
> Scrolling around the only thing I see that doesn't seem to be addressed by
> this commit is a complaint about get_bc_algorithm_name falling off the end.
Well, there's also the test failure on windows...
> I've added a dummy return statement to hopefully address that.
Assert(false); won't help a compiler to see the path is unreachable when
building without assertions. Might be nicer to use pg_unreachable().
Greetings,
Andres Freund
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients from your mail client; the link fills in
the headers below: reply via email
Some clients, webmail especially, drop In-Reply-To and References from
a link, and the reply then starts a new thread: use the mbox below.
To: pgsql-committers@postgresql.org
Cc: andres@anarazel.de, robertmhaas@gmail.com
Subject: Re: pgsql: Unbreak the build.
In-Reply-To: <20220323154948.izypvuod5ddgyj46@alap3.anarazel.de>
References: <E1nX1uH-0011tI-8h@gemulon.postgresql.org> <C6A7643A-582B-47F7-A03D-01736BC0349B@anarazel.de> <CA+TgmoandqPXmJt5JGq3zhNg4geUv0ruj9C8P+gRY3+z50CPww@mail.gmail.com> <20220323154948.izypvuod5ddgyj46@alap3.anarazel.de>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox