pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Justin Pryzby <pryzby@telsasoft.com>
To: Andres Freund <andres@anarazel.de>
Cc: Robert Haas <robertmhaas@gmail.com>
Cc: pgsql-hackers@lists.postgresql.org, Magnus Hagander <magnus@hagander.net>
Subject: Re: pgsql: Add 'basebackup_to_shell' contrib module.
Date: Fri, 25 Mar 2022 22:13:53 -0500
Message-ID: <20220326031353.GG28503@telsasoft.com> (raw)
In-Reply-To: <20220325212707.fkevorahowgur5ux@alap3.anarazel.de>
References: <E1nUB2m-000CYD-DY@gemulon.postgresql.org>
	<20220315190428.2xf6klawmaq4nuyy@alap3.anarazel.de>
	<CA+TgmoZZJK7Tx1aG2yTsaOTuCdjQkB0wY9vNCTSqf7tAubtZAQ@mail.gmail.com>
	<CA+TgmoagO0Dofpy8PUyphNXaTovqRCpYOQuP+BKPeSe3kH1zJw@mail.gmail.com>
	<626827E9-4A50-493D-A8EE-EB3C238BB47F@anarazel.de>
	<CA+TgmoZ6DdRe0=YYv-dXfKCpfwaoKdUXP6gXg7qVB=3FwON1GA@mail.gmail.com>
	<20220325212707.fkevorahowgur5ux@alap3.anarazel.de>

On Fri, Mar 25, 2022 at 02:27:07PM -0700, Andres Freund wrote:
> On 2022-03-25 13:52:11 -0400, Robert Haas wrote:
> > On Fri, Mar 25, 2022 at 12:36 PM Andres Freund <andres@anarazel.de> wrote:
> > > Create a CF entry for it, or enable CI on a github repo?
> >
> > I created a CF entry for it. Then I had to try to Google around to
> > find the URL from the cfbot, because it's not even linked from
> > commitfest.postgresql.org for some reason. #blamemagnus

I see it here (and in cfbot), although I'm not sure how you created a new
patch for the active CF, and not for the next CF.
https://commitfest.postgresql.org/37/

> > I don't think that the Windows CI is running the TAP tests for
> > contrib. At least, I can't find any indication of it in the output. So
> > it doesn't really help to assess how portable this test is, unless I'm
> > missing something.
> 
> Yea. It's really unfortunate how vcregress.pl makes it hard to run all
> tests. And we're kind of stuck finding a way forward. It's easy enough to work
> around for individual tests by just adding them to the test file (like Thomas
> did nearby), but clearly that doesn't scale. Andrew wasn't happy with
> additional vcregress commands. The fact that vcregress doesn't run tests in
> parallel makes things take forever. And so it goes on.

I have a patch to add alltaptests target to vcregress.  But I don't recall
hearing any objection to new targets until now.

https://github.com/justinpryzby/postgres/runs/5174877506





view thread (66+ messages)  latest in thread

Message-ID: <20220326031353.GG28503@telsasoft.com>
Permalink:  ../20220326031353.GG28503@telsasoft.com/
Also on:    postgresql.org/message-id/20220326031353.GG28503@telsasoft.com

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: pryzby@telsasoft.com, andres@anarazel.de, robertmhaas@gmail.com, magnus@hagander.net
  Subject: Re: pgsql: Add 'basebackup_to_shell' contrib module.
  In-Reply-To: <20220326031353.GG28503@telsasoft.com>
  References: <E1nUB2m-000CYD-DY@gemulon.postgresql.org> <20220315190428.2xf6klawmaq4nuyy@alap3.anarazel.de> <CA+TgmoZZJK7Tx1aG2yTsaOTuCdjQkB0wY9vNCTSqf7tAubtZAQ@mail.gmail.com> <CA+TgmoagO0Dofpy8PUyphNXaTovqRCpYOQuP+BKPeSe3kH1zJw@mail.gmail.com> <626827E9-4A50-493D-A8EE-EB3C238BB47F@anarazel.de> <CA+TgmoZ6DdRe0=YYv-dXfKCpfwaoKdUXP6gXg7qVB=3FwON1GA@mail.gmail.com> <20220325212707.fkevorahowgur5ux@alap3.anarazel.de> <20220326031353.GG28503@telsasoft.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox