pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Andres Freund <andres@anarazel.de>
To: Robert Haas <robertmhaas@gmail.com>
Cc: Andrew Dunstan <andrew@dunslane.net>
Cc: Thomas Munro <thomas.munro@gmail.com>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Cc: Magnus Hagander <magnus@hagander.net>
Subject: Re: pgsql: Add 'basebackup_to_shell' contrib module.
Date: Wed, 30 Mar 2022 09:54:50 -0700
Message-ID: <20220330165450.3lruwky7eveddsvq@alap3.anarazel.de> (raw)
In-Reply-To: <CA+TgmoaZ6L37kVJPRDavbtRa+wq-vtBkd3L9s=B7d91BF-UW4Q@mail.gmail.com>
References: <CA+Tgmoat+zbzzZQJ7poXyUwiqxQxTaUid=auB4FejZ15VvDh4Q@mail.gmail.com>
	<CA+hUKGK_J2XmrhVToBfnhnAaQVP0r5C1b6ae5Kc15cSQNMgdWw@mail.gmail.com>
	<CA+hUKGK6U1PASzxGCA_c21EQ9mKbn3qyWvMB74y=X8Kjby5rtw@mail.gmail.com>
	<CA+TgmoYUTKqBDH7FZ99baN8yECe-CGeqgigjM=FyQYe2BXiZEg@mail.gmail.com>
	<20220329222504.aylyimyub6igsvpy@alap3.anarazel.de>
	<CA+hUKGLUosJyfUBT+DAN8WzTi9eqaD6-rDwnWfvfsa6mfKUcvw@mail.gmail.com>
	<684ed71e-0876-60c0-8e44-066ba702f0a6@dunslane.net>
	<CA+TgmoYf9wE56eAc5x8g33ta1GbNEAN4CcvdhDNs+Rg4OfzaHQ@mail.gmail.com>
	<20220330163024.fsbpbxwxh5oo2ktx@alap3.anarazel.de>
	<CA+TgmoaZ6L37kVJPRDavbtRa+wq-vtBkd3L9s=B7d91BF-UW4Q@mail.gmail.com>

Hi,

On 2022-03-30 12:42:50 -0400, Robert Haas wrote:
> On Wed, Mar 30, 2022 at 12:30 PM Andres Freund <andres@anarazel.de> wrote:
> > # Reconfigure to restrict access and require a detail.
> > $shell_command =
> >         $PostgreSQL::Test::Utils::windows_os
> >         ? qq{$gzip --fast > "$escaped_backup_path\\\\%d.%f.gz"}
> >     : qq{$gzip --fast > "$escaped_backup_path/%d.%f.gz"};
> >
> > I don't think the branch is needed anymore, forward slashes should work for
> > output redirection.
> 
> We have similar things in src/test/perl/PostgreSQL/Test/Cluster.pm.

There are some commandline utilities (including copy) where backward slashes
in arguments are necessary, to separate options from paths :/. Those are the
extent of backslash use in Cluster.pm that I could see quickly.


> I'm not sure it's the place of this patch to introduce a mix of styles.

Fair enough. I found it a bit grating to read in the test, that's why I
mentioned it...

Greetings,

Andres Freund





view thread (66+ messages)  latest in thread

Message-ID: <20220330165450.3lruwky7eveddsvq@alap3.anarazel.de>
Permalink:  ../20220330165450.3lruwky7eveddsvq@alap3.anarazel.de/
Also on:    postgresql.org/message-id/20220330165450.3lruwky7eveddsvq@alap3.anarazel.de

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: andres@anarazel.de, robertmhaas@gmail.com, andrew@dunslane.net, thomas.munro@gmail.com, pgsql-hackers@lists.postgresql.org, magnus@hagander.net
  Subject: Re: pgsql: Add 'basebackup_to_shell' contrib module.
  In-Reply-To: <20220330165450.3lruwky7eveddsvq@alap3.anarazel.de>
  References: <CA+Tgmoat+zbzzZQJ7poXyUwiqxQxTaUid=auB4FejZ15VvDh4Q@mail.gmail.com> <CA+hUKGK_J2XmrhVToBfnhnAaQVP0r5C1b6ae5Kc15cSQNMgdWw@mail.gmail.com> <CA+hUKGK6U1PASzxGCA_c21EQ9mKbn3qyWvMB74y=X8Kjby5rtw@mail.gmail.com> <CA+TgmoYUTKqBDH7FZ99baN8yECe-CGeqgigjM=FyQYe2BXiZEg@mail.gmail.com> <20220329222504.aylyimyub6igsvpy@alap3.anarazel.de> <CA+hUKGLUosJyfUBT+DAN8WzTi9eqaD6-rDwnWfvfsa6mfKUcvw@mail.gmail.com> <684ed71e-0876-60c0-8e44-066ba702f0a6@dunslane.net> <CA+TgmoYf9wE56eAc5x8g33ta1GbNEAN4CcvdhDNs+Rg4OfzaHQ@mail.gmail.com> <20220330163024.fsbpbxwxh5oo2ktx@alap3.anarazel.de> <CA+TgmoaZ6L37kVJPRDavbtRa+wq-vtBkd3L9s=B7d91BF-UW4Q@mail.gmail.com> <20220330165450.3lruwky7eveddsvq@alap3.anarazel.de>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox