From: Kyotaro Horiguchi <horikyota.ntt@gmail.com>
To: robertmhaas@gmail.com
Cc: markus.wanner@enterprisedb.com
Cc: pgsql-hackers@postgresql.org
Subject: Re: API stability
Date: Wed, 06 Apr 2022 16:45:21 +0900 (JST)
Message-ID: <20220406.164521.17171257901083417.horikyota.ntt@gmail.com> (raw)
In-Reply-To: <20220406.155332.1780268842430625734.horikyota.ntt@gmail.com>
References: <20220406.143037.1305948883608926192.horikyota.ntt@gmail.com>
<20220406.153153.746094489184530420.horikyota.ntt@gmail.com>
<20220406.155332.1780268842430625734.horikyota.ntt@gmail.com>
At Wed, 06 Apr 2022 15:53:32 +0900 (JST), Kyotaro Horiguchi <horikyota.ntt@gmail.com> wrote in
> At Wed, 06 Apr 2022 15:31:53 +0900 (JST), Kyotaro Horiguchi <horikyota.ntt@gmail.com> wrote in
> > At Wed, 06 Apr 2022 14:30:37 +0900 (JST), Kyotaro Horiguchi <horikyota.ntt@gmail.com> wrote in
> > > So if we don't want to move any member in PGPROC, we do:
> > >
> > > 14: after statusFlags.
> > > 13: after delayChkpt.
> > > 12-10: after syncRepState (and before syncRepLinks).
> > >
> > > If we allow to shift some members, the new flag can be placed more
> > > saner place.
> > >
> > > 14: after delayChkpt ((uint8)statusFlags moves forward by 1 byte)
> > > 13: after delayChkpt (no member moves)
> > > 12-10: after subxids ((bool)procArrayGroupMember moves forward by 1 byte)
> > >
> > > I continue working on the last direction above.
> >
> > Hmm. That is ABI break. I go with the first way.
>
> By the way, the patch for -14 changed the sigunature of two public
> functions.
>
> -GetVirtualXIDsDelayingChkpt(int *nvxids)
> +GetVirtualXIDsDelayingChkpt(int *nvxids, int type)
>
> -HaveVirtualXIDsDelayingChkpt(VirtualTransactionId *vxids, int nvxids)
> +HaveVirtualXIDsDelayingChkpt(VirtualTransactionId *vxids, int nvxids, int type)
>
> Do I need to restore the signature?
For master, renamed delayChkpt to delayChkptFlags and changed it to uint8.
For 14, restored delayChkpt to bool and added delayChkptEnd into a gap in PGPROC, then restored the signature of the two functions above to before the patch. Then added a new functions ..DelayingChkptEnd().
regards.
--
Kyotaro Horiguchi
NTT Open Source Software Center
Attachments:
v1-0001-Rename-and-change-type-of-delayChkpt.patch (text/x-patch, 0B) download
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients from your mail client; the link fills in
the headers below: reply via email
Some clients, webmail especially, drop In-Reply-To and References from
a link, and the reply then starts a new thread: use the mbox below.
To: pgsql-committers@postgresql.org
Cc: horikyota.ntt@gmail.com, robertmhaas@gmail.com, markus.wanner@enterprisedb.com, pgsql-hackers@postgresql.org
Subject: Re: API stability
In-Reply-To: <20220406.164521.17171257901083417.horikyota.ntt@gmail.com>
References: <20220406.143037.1305948883608926192.horikyota.ntt@gmail.com> <20220406.153153.746094489184530420.horikyota.ntt@gmail.com> <20220406.155332.1780268842430625734.horikyota.ntt@gmail.com> <20220406.164521.17171257901083417.horikyota.ntt@gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox