From: Kyotaro Horiguchi <horikyota.ntt@gmail.com>
To: michael@paquier.xyz
Cc: robertmhaas@gmail.com
Cc: tgl@sss.pgh.pa.us
Cc: markus.wanner@enterprisedb.com
Cc: pgsql-hackers@postgresql.org
Subject: Re: API stability
Date: Fri, 08 Apr 2022 10:32:55 +0900 (JST)
Message-ID: <20220408.103255.1640071788970978147.horikyota.ntt@gmail.com> (raw)
In-Reply-To: <Yk94Hvnrx1V00skb@paquier.xyz>
References: <2358496.1649168259@sss.pgh.pa.us>
<CA+Tgmoao-kUD9c5nG5sub3F7tbo39+cdr8jKaOVEs_1aBWcJ3Q@mail.gmail.com>
<Yk94Hvnrx1V00skb@paquier.xyz>
At Fri, 8 Apr 2022 08:47:42 +0900, Michael Paquier <michael@paquier.xyz> wrote in
> On Thu, Apr 07, 2022 at 11:19:15AM -0400, Robert Haas wrote:
> > Here are patches for master and v14 to do things this way. Comments?
>
> Thanks for the patches. They look correct. For ~14, I'd rather avoid
> the code duplication done by GetVirtualXIDsDelayingChkptEnd() and
> HaveVirtualXIDsDelayingChkpt() that could be avoided with an extra
> bool argument to the existing routine. The same kind of duplication
> happens with GetVirtualXIDsDelayingChkpt() and
> GetVirtualXIDsDelayingChkptEnd().
FWIW, it is done in [1].
[1] https://www.postgresql.org/message-id/20220406.164521.17171257901083417.horikyota.ntt%40gmail.com
regards.
--
Kyotaro Horiguchi
NTT Open Source Software Center
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients from your mail client; the link fills in
the headers below: reply via email
Some clients, webmail especially, drop In-Reply-To and References from
a link, and the reply then starts a new thread: use the mbox below.
To: pgsql-committers@postgresql.org
Cc: horikyota.ntt@gmail.com, michael@paquier.xyz, robertmhaas@gmail.com, tgl@sss.pgh.pa.us, markus.wanner@enterprisedb.com, pgsql-hackers@postgresql.org
Subject: Re: API stability
In-Reply-To: <20220408.103255.1640071788970978147.horikyota.ntt@gmail.com>
References: <2358496.1649168259@sss.pgh.pa.us> <CA+Tgmoao-kUD9c5nG5sub3F7tbo39+cdr8jKaOVEs_1aBWcJ3Q@mail.gmail.com> <Yk94Hvnrx1V00skb@paquier.xyz> <20220408.103255.1640071788970978147.horikyota.ntt@gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox