pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Andres Freund <andres@anarazel.de>
To: Amit Kapila <amit.kapila16@gmail.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Amit Kapila <akapila@postgresql.org>
Cc: pgsql-committers <pgsql-committers@lists.postgresql.org>
Subject: Re: pgsql: Extend pg_publication_tables to display column list and row filt
Date: Sat, 28 May 2022 13:30:17 -0700
Message-ID: <20220528203017.l623lrc2ak45xry6@alap3.anarazel.de> (raw)
In-Reply-To: <CAA4eK1JB_AqdQOaVGsV-RhFRCZo62m4mpn51aVNFH+suOitmrg@mail.gmail.com>
References: <E1nrWRR-0003J6-Hc@gemulon.postgresql.org>
	<91075.1652929852@sss.pgh.pa.us>
	<CAA4eK1JB_AqdQOaVGsV-RhFRCZo62m4mpn51aVNFH+suOitmrg@mail.gmail.com>

Hi,

On 2022-05-19 08:59:13 +0530, Amit Kapila wrote:
> On Thu, May 19, 2022 at 8:40 AM Tom Lane <tgl@sss.pgh.pa.us> wrote:
> >
> > Amit Kapila <akapila@postgresql.org> writes:
> > > Extend pg_publication_tables to display column list and row filter.
> >
> > Is this really something to be doing post-beta1?
> >
> 
> I am sorry if we don't allow to make catalog changes post-beta1.

I don't think there's a hard prohibition of catalog changes. But we should be
careful doing them because it makes testing more painful etc.


> If we can't do that then I can revert this and try to find a different
> solution to the problem?

What "problem"? This just seems like a feature in a problem's clothing? The
commit message says:

> This information will be useful to users and we also need this for the
> later commit that prohibits combining multiple publications with different
> column lists for the same table.

which doesn't at all strike me as a justification for committing it post
feature freeze, i.e. it sounds like a feature.

If you want to argue that it's a rough corner in v15 work, that it's worth
committing now, do that explicitly.

Greetings,

Andres Freund





view thread (5+ messages)  latest in thread

Message-ID: <20220528203017.l623lrc2ak45xry6@alap3.anarazel.de>
Permalink:  ../20220528203017.l623lrc2ak45xry6@alap3.anarazel.de/
Also on:    postgresql.org/message-id/20220528203017.l623lrc2ak45xry6@alap3.anarazel.de

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: andres@anarazel.de, amit.kapila16@gmail.com, tgl@sss.pgh.pa.us, akapila@postgresql.org
  Subject: Re: pgsql: Extend pg_publication_tables to display column list and row filt
  In-Reply-To: <20220528203017.l623lrc2ak45xry6@alap3.anarazel.de>
  References: <E1nrWRR-0003J6-Hc@gemulon.postgresql.org> <91075.1652929852@sss.pgh.pa.us> <CAA4eK1JB_AqdQOaVGsV-RhFRCZo62m4mpn51aVNFH+suOitmrg@mail.gmail.com> <20220528203017.l623lrc2ak45xry6@alap3.anarazel.de>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox