From: Alvaro Herrera <alvherre@alvh.no-ip.org>
To: Robert Haas <rhaas@postgresql.org>
Cc: pgsql-hackers@lists.postgresql.org
Subject: Re: pgsql: Remove the restriction that the relmap must be 512 bytes.
Date: Wed, 27 Jul 2022 19:19:39 +0200
Message-ID: <20220727171939.6ixixqcjt5riil2o@alvherre.pgsql> (raw)
In-Reply-To: <E1oGPwj-001NZa-73@gemulon.postgresql.org>
On 2022-Jul-26, Robert Haas wrote:
> Remove the restriction that the relmap must be 512 bytes.
>
> Instead of relying on the ability to atomically overwrite the
> entire relmap file in one shot, write a new one and durably
> rename it into place. Removing the struct padding and the
> calculation showing why the map is exactly 512 bytes, and change
> the maximum number of entries to a nearby round number.
Another thing that seems to have happened here is that catversion ought
to have been touched and wasn't. Trying to start a cluster that was
initdb'd with the previous code enters an infinite loop that dies each
time with
2022-07-27 19:17:27.589 CEST [2516547] LOG: database system is ready to accept connections
2022-07-27 19:17:27.589 CEST [2516730] FATAL: could not read file "global/pg_filenode.map": read 512 of 524
2022-07-27 19:17:27.589 CEST [2516731] FATAL: could not read file "global/pg_filenode.map": read 512 of 524
2022-07-27 19:17:27.589 CEST [2516547] LOG: autovacuum launcher process (PID 2516730) exited with exit code 1
2022-07-27 19:17:27.589 CEST [2516547] LOG: terminating any other active server processes
Perhaps we should still do a catversion bump now, since one hasn't
happened since the commit.
--
Álvaro Herrera 48°01'N 7°57'E — https://www.EnterpriseDB.com/
"El número de instalaciones de UNIX se ha elevado a 10,
y se espera que este número aumente" (UPM, 1972)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients from your mail client; the link fills in
the headers below: reply via email
Some clients, webmail especially, drop In-Reply-To and References from
a link, and the reply then starts a new thread: use the mbox below.
To: pgsql-committers@postgresql.org
Cc: alvherre@alvh.no-ip.org, rhaas@postgresql.org, pgsql-hackers@lists.postgresql.org
Subject: Re: pgsql: Remove the restriction that the relmap must be 512 bytes.
In-Reply-To: <20220727171939.6ixixqcjt5riil2o@alvherre.pgsql>
References: <E1oGPwj-001NZa-73@gemulon.postgresql.org> <20220727171939.6ixixqcjt5riil2o@alvherre.pgsql>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox