From: Alvaro Herrera <alvherre@alvh.no-ip.org>
To: Robert Haas <robertmhaas@gmail.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: pgsql: Remove the restriction that the relmap must be 512 bytes.
Date: Wed, 27 Jul 2022 20:45:23 +0200
Message-ID: <20220727184523.n7emhydwhnegd2ci@alvherre.pgsql> (raw)
In-Reply-To: <CA+TgmobUHsQ7orynyuZaDyf7=o6H66SUTDN0ZtMxGzqiXTSpDA@mail.gmail.com>
On 2022-Jul-27, Robert Haas wrote:
> Hmm, but that doesn't actually produce nice behavior. It just goes
> into an infinite loop, like this:
> 2022-07-27 14:21:12.869 EDT [32853] FATAL: relation mapping file
> "global/pg_filenode.map" contains invalid data
This seems almost identical what happens without the version number
change, so I wouldn't call it much of an improvement.
> While I agree that changing a version identifier that is more closely
> related to what got changed is better than changing a generic one, I
> think people won't like an infinite loop that spews messages into the
> log at top speed as a way of telling them about the problem.
>
> So now I'm back to being unsure what to do here.
I vote to go for the catversion bump for now.
Maybe it's possible to patch the relmapper code afterwards, so that if a
version mismatch is detected the server is stopped with a reasonable
message. An hypothetical improvement would be to keep the code to read
the old version and upgrade the file automatically, but given the number
of times that this file has changed, it's likely pointless effort.
Therefore, my proposal is to add a comment next to the struct definition
suggesting to bump catversion and call it a day.
--
Álvaro Herrera PostgreSQL Developer — https://www.EnterpriseDB.com/
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients from your mail client; the link fills in
the headers below: reply via email
Some clients, webmail especially, drop In-Reply-To and References from
a link, and the reply then starts a new thread: use the mbox below.
To: pgsql-committers@postgresql.org
Cc: alvherre@alvh.no-ip.org, robertmhaas@gmail.com, tgl@sss.pgh.pa.us, pgsql-hackers@lists.postgresql.org
Subject: Re: pgsql: Remove the restriction that the relmap must be 512 bytes.
In-Reply-To: <20220727184523.n7emhydwhnegd2ci@alvherre.pgsql>
References: <CA+TgmobUHsQ7orynyuZaDyf7=o6H66SUTDN0ZtMxGzqiXTSpDA@mail.gmail.com> <20220727184523.n7emhydwhnegd2ci@alvherre.pgsql>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox