pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Alvaro Herrera <alvherre@alvh.no-ip.org>
To: Andres Freund <andres@anarazel.de>
Cc: pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Rely on __func__ being supported
Date: Wed, 10 Aug 2022 16:03:34 +0200
Message-ID: <20220810140334.itf5rw4mvfmojnuu@alvherre.pgsql> (raw)
In-Reply-To: <20220807174525.tbsrestw63ngblqf@awork3.anarazel.de>

Hello

On 2022-Aug-07, Andres Freund wrote:

> On 2022-08-07 19:40:14 +0200, Alvaro Herrera wrote:
> > I'd rather we keep PG_FUNCNAME_MACRO defined to __func__ ... it costs us
> > nothing.  Would anybody oppose that?
> 
> I'm fine with re-adding the macro, as long as we don't re-add in-tree users.

After further thinking, I conclude there's no need for this.  It's quite
easy to add a "#ifndef PG_FUNCNAME_MACRO" stanza in third-party code if
needed, and just rely on __func__ otherwise.

Thanks

-- 
Álvaro Herrera               48°01'N 7°57'E  —  https://www.EnterpriseDB.com/





view thread (4+ messages)

Message-ID: <20220810140334.itf5rw4mvfmojnuu@alvherre.pgsql>
Permalink:  ../20220810140334.itf5rw4mvfmojnuu@alvherre.pgsql/
Also on:    postgresql.org/message-id/20220810140334.itf5rw4mvfmojnuu@alvherre.pgsql

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: alvherre@alvh.no-ip.org, andres@anarazel.de
  Subject: Re: pgsql: Rely on __func__ being supported
  In-Reply-To: <20220810140334.itf5rw4mvfmojnuu@alvherre.pgsql>
  References: <20220807174525.tbsrestw63ngblqf@awork3.anarazel.de> <20220810140334.itf5rw4mvfmojnuu@alvherre.pgsql>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox