pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Justin Pryzby <pryzby@telsasoft.com>
To: Peter Eisentraut <peter@eisentraut.org>
Cc: pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Remove unnecessary casts in free() and pfree()
Date: Sat, 27 Aug 2022 06:23:04 -0500
Message-ID: <20220827112304.GL2342@telsasoft.com> (raw)
In-Reply-To: <E1oRZup-001ImD-Vl@gemulon.postgresql.org>
References: <E1oRZup-001ImD-Vl@gemulon.postgresql.org>

On Fri, Aug 26, 2022 at 02:02:33PM +0000, Peter Eisentraut wrote:
> Remove unnecessary casts in free() and pfree()

This seems to be breaking cfbot's "warnings" test.

[07:49:48.983] label.c:665:10: error: passing argument 1 of ‘pfree’ discards ‘const’ qualifier from pointer target type [-Werror=discarded-qualifiers]
[07:49:48.983]   665 |    pfree(temp);

I imagine it would've been reported earlier, except that this commit was within
60min of the commit that broke perl.

-- 
Justin





view thread (4+ messages)  latest in thread

Message-ID: <20220827112304.GL2342@telsasoft.com>
Permalink:  ../20220827112304.GL2342@telsasoft.com/
Also on:    postgresql.org/message-id/20220827112304.GL2342@telsasoft.com

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: pryzby@telsasoft.com, peter@eisentraut.org
  Subject: Re: pgsql: Remove unnecessary casts in free() and pfree()
  In-Reply-To: <20220827112304.GL2342@telsasoft.com>
  References: <E1oRZup-001ImD-Vl@gemulon.postgresql.org> <20220827112304.GL2342@telsasoft.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox