pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Julien Rouhaud <rjuju123@gmail.com>
To: John Naylor <john.naylor@postgresql.org>
Cc: pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Fix broken cast on MSVC
Date: Tue, 30 Aug 2022 10:26:36 +0800
Message-ID: <20220830022636.qrcbcecmhztbxrwa@jrouhaud> (raw)
In-Reply-To: <E1oScH1-000RbK-8z@gemulon.postgresql.org>
References: <E1oScH1-000RbK-8z@gemulon.postgresql.org>

Hi,

On Mon, Aug 29, 2022 at 10:45:43AM +0000, John Naylor wrote:
>
> +/*
> + * Exactly like vector32_is_highbit_set except for the input type, so it
> + * looks at each byte separately.
> + *
> + * [...]
> + */
> +#ifndef USE_NO_SIMD
> +static inline bool
> +vector32_is_highbit_set(const Vector32 v)
> [...]

Shouldn't the comment be "Exactly like vector8_is_highbit_set..."?

Also, is there any reason to not have a function prototype for this one?  As
far as I can see that's the only one that doesn't in simd.h.





view thread (3+ messages)  latest in thread

Message-ID: <20220830022636.qrcbcecmhztbxrwa@jrouhaud>
Permalink:  ../20220830022636.qrcbcecmhztbxrwa@jrouhaud/
Also on:    postgresql.org/message-id/20220830022636.qrcbcecmhztbxrwa@jrouhaud

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: rjuju123@gmail.com, john.naylor@postgresql.org
  Subject: Re: pgsql: Fix broken cast on MSVC
  In-Reply-To: <20220830022636.qrcbcecmhztbxrwa@jrouhaud>
  References: <E1oScH1-000RbK-8z@gemulon.postgresql.org> <20220830022636.qrcbcecmhztbxrwa@jrouhaud>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox