pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Andres Freund <andres@anarazel.de>
To: John Naylor <john.naylor@enterprisedb.com>
Cc: John Naylor <john.naylor@postgresql.org>
Cc: pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Build all Flex files standalone
Date: Sun, 4 Sep 2022 13:57:43 -0700
Message-ID: <20220904205743.y3ntq6ij3aibmxvy@awork3.anarazel.de> (raw)
In-Reply-To: <CAFBsxsGsF+XO_mNoU1QhLB1U70DXbxXPjcyfF4km5ww+Y7e6Vw@mail.gmail.com>
References: <E1oUhv4-001MaA-Et@gemulon.postgresql.org>
	<CAFBsxsGVJ6pYVAPGFd4M0Bi=r3ocWJ5Lt5MEq+iwGWkRfb_w+g@mail.gmail.com>
	<CAFBsxsGsF+XO_mNoU1QhLB1U70DXbxXPjcyfF4km5ww+Y7e6Vw@mail.gmail.com>

Hi,

On 2022-09-04 18:04:13 +0700, John Naylor wrote:
> On Sun, Sep 4, 2022 at 4:36 PM John Naylor <john.naylor@enterprisedb.com> wrote:
> >
> > For this, Mkvcbuild.pm specifies specparse.c explicitly, so maybe
> > something like the following is needed:
> >
> > --- a/src/tools/msvc/Mkvcbuild.pm
> > +++ b/src/tools/msvc/Mkvcbuild.pm
> > @@ -362,6 +362,7 @@ sub mkvcbuild
> >         $isolation_tester->AddFile('src/test/isolation/specparse.y');
> >         $isolation_tester->AddFile('src/test/isolation/specscanner.l');
> >         $isolation_tester->AddFile('src/test/isolation/specparse.c');
> > +       $isolation_tester->AddFile('src/test/isolation/specscanner.c');
> >         $isolation_tester->AddIncludeDir('src/test/isolation');
> 
> This gets CI green (tip o' the hat to Thomas Munro for off-list advice
> on getting that working), so pushed.

It doesn't seem to have gotten all of CI green, cpluspluscheck fails:
https://cirrus-ci.com/task/6561938334285824

I think this just needs a copy the logic you added to headerscheck also to
cpluspluscheck (and yes, we should merge these files one of these days).

Greetings,

Andres Freund





view thread (14+ messages)  latest in thread

Message-ID: <20220904205743.y3ntq6ij3aibmxvy@awork3.anarazel.de>
Permalink:  ../20220904205743.y3ntq6ij3aibmxvy@awork3.anarazel.de/
Also on:    postgresql.org/message-id/20220904205743.y3ntq6ij3aibmxvy@awork3.anarazel.de

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: andres@anarazel.de, john.naylor@enterprisedb.com, john.naylor@postgresql.org
  Subject: Re: pgsql: Build all Flex files standalone
  In-Reply-To: <20220904205743.y3ntq6ij3aibmxvy@awork3.anarazel.de>
  References: <E1oUhv4-001MaA-Et@gemulon.postgresql.org> <CAFBsxsGVJ6pYVAPGFd4M0Bi=r3ocWJ5Lt5MEq+iwGWkRfb_w+g@mail.gmail.com> <CAFBsxsGsF+XO_mNoU1QhLB1U70DXbxXPjcyfF4km5ww+Y7e6Vw@mail.gmail.com> <20220904205743.y3ntq6ij3aibmxvy@awork3.anarazel.de>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox