From: Andres Freund <andres@anarazel.de>
To: John Naylor <john.naylor@enterprisedb.com>
Cc: John Naylor <john.naylor@postgresql.org>
Cc: pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Build all Flex files standalone
Date: Sun, 4 Sep 2022 14:08:12 -0700
Message-ID: <20220904210812.icxugcz2syyts3ef@awork3.anarazel.de> (raw)
In-Reply-To: <CAFBsxsE3Cx_n1TS7cEtCX1fOpuZYEDqzHFZQUZvSHk7vfDFNAA@mail.gmail.com>
References: <E1oUhv4-001MaA-Et@gemulon.postgresql.org>
<CAFBsxsE3Cx_n1TS7cEtCX1fOpuZYEDqzHFZQUZvSHk7vfDFNAA@mail.gmail.com>
Hi,
On 2022-09-04 13:19:56 +0700, John Naylor wrote:
> Crake fails with
>
> headerscheck:
> Sep 04 01:56:01 In file included from /tmp/headerscheck.UNgmKy/test.c:2:
> Sep 04 01:56:01
> /home/andrew/bf/root/HEAD/pgsql.build/../pgsql/src/backend/utils/adt/jsonpath_internal.h:26:10:
> fatal error: jsonpath_gram.h: No such file or directory
> Sep 04 01:56:01 26 | #include "jsonpath_gram.h"
> Sep 04 01:56:01 | ^~~~~~~~~~~~~~~~~
> Sep 04 01:56:01 compilation terminated.
> Sep 04 01:56:14 make: *** [GNUmakefile:138: headerscheck] Error 1
> cpluspluscheck:
> Sep 04 01:57:19 In file included from /tmp/cpluspluscheck.HhRV5k/test.cpp:3:
> Sep 04 01:57:19
> /home/andrew/bf/root/HEAD/pgsql.build/../pgsql/src/backend/utils/adt/jsonpath_internal.h:26:10:
> fatal error: jsonpath_gram.h: No such file or directory
> Sep 04 01:57:19 26 | #include "jsonpath_gram.h"
> Sep 04 01:57:19 | ^~~~~~~~~~~~~~~~~
>
> I don't get the same in an already-built tree. I also don't see an
> exception for gramparse.h, which I imagine would have the same issue?
It doesn't happen for gramparse.h because gram.h is copied to
src/include/parser (see src/backend/Makefile), and included as parser/gram.h.
I think this could be addressed by always adding something like
-iquote $builddir/$(dirname "$f") -iquote $srcdir/$(dirname "$f") \
to cpluspluscheck/headerscheck.
Greetings,
Andres Freund
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients from your mail client; the link fills in
the headers below: reply via email
Some clients, webmail especially, drop In-Reply-To and References from
a link, and the reply then starts a new thread: use the mbox below.
To: pgsql-committers@postgresql.org
Cc: andres@anarazel.de, john.naylor@enterprisedb.com, john.naylor@postgresql.org
Subject: Re: pgsql: Build all Flex files standalone
In-Reply-To: <20220904210812.icxugcz2syyts3ef@awork3.anarazel.de>
References: <E1oUhv4-001MaA-Et@gemulon.postgresql.org> <CAFBsxsE3Cx_n1TS7cEtCX1fOpuZYEDqzHFZQUZvSHk7vfDFNAA@mail.gmail.com> <20220904210812.icxugcz2syyts3ef@awork3.anarazel.de>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox