From: Alvaro Herrera <alvherre@alvh.no-ip.org>
To: Thomas Munro <thomas.munro@gmail.com>
Cc: Thomas Munro <tmunro@postgresql.org>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: pgsql: Prefetch data referenced by the WAL, take II.
Date: Tue, 13 Sep 2022 12:07:40 +0200
Message-ID: <20220913100740.cgt3cddnrjt3syuu@alvherre.pgsql> (raw)
In-Reply-To: <CA+hUKGJ9wP9kpvgoxHvqA=4g1d9-y_w3LhhdhFVU=mFiqjwHww@mail.gmail.com>
On 2022-Sep-13, Thomas Munro wrote:
> I'd go for your second suggestion. 'therein' doesn't convey much (we
> already said 'in the WAL', and therein is just a slightly formal and
> somehow more Germanic way of saying 'in it' which is kinda
> duplicative; maybe 'by it' is what we want but that's still kinda
> implied already), whereas adding 'data' makes it slightly clearer that
> it's blocks from relations and not, say, the WAL itself.
>
> Also, hmm, it's not really the 'Maximum buffer size', it's the 'Buffer size'.
Sounds reasonable. Pushed these changes. Thank you!
--
Álvaro Herrera 48°01'N 7°57'E — https://www.EnterpriseDB.com/
"La libertad es como el dinero; el que no la sabe emplear la pierde" (Alvarez)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients from your mail client; the link fills in
the headers below: reply via email
Some clients, webmail especially, drop In-Reply-To and References from
a link, and the reply then starts a new thread: use the mbox below.
To: pgsql-committers@postgresql.org
Cc: alvherre@alvh.no-ip.org, thomas.munro@gmail.com, tmunro@postgresql.org, pgsql-hackers@lists.postgresql.org
Subject: Re: pgsql: Prefetch data referenced by the WAL, take II.
In-Reply-To: <20220913100740.cgt3cddnrjt3syuu@alvherre.pgsql>
References: <CA+hUKGJ9wP9kpvgoxHvqA=4g1d9-y_w3LhhdhFVU=mFiqjwHww@mail.gmail.com> <20220913100740.cgt3cddnrjt3syuu@alvherre.pgsql>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox