pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Andres Freund <andres@anarazel.de>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Noah Misch <noah@leadboat.com>
Cc: pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: aix: No need to use mkldexport when we want to export all symbol
Date: Tue, 13 Sep 2022 11:25:30 -0700
Message-ID: <20220913182530.4yq35ralujjsv2k3@awork3.anarazel.de> (raw)
In-Reply-To: <20220911181925.ygxbync3uk5ezcic@awork3.anarazel.de>
References: <E1oWpzF-002EG4-AG@gemulon.postgresql.org>
	<325593.1662783266@sss.pgh.pa.us>
	<89D645BA-FF97-4516-A21D-9FC4A4B31F8C@anarazel.de>
	<20220910043749.koidc5k4j5dxo3if@awork3.anarazel.de>
	<20220910052741.t7w7csyrggwus2ze@awork3.anarazel.de>
	<338810.1662787972@sss.pgh.pa.us>
	<20220910055736.htsr5juo3ldlay2l@awork3.anarazel.de>
	<20220910081944.oiayp5lky3kv2o43@awork3.anarazel.de>
	<20220911181925.ygxbync3uk5ezcic@awork3.anarazel.de>

Hi,

On 2022-09-11 11:19:25 -0700, Andres Freund wrote:
> We could also try to fall back to using -Wl,b,expall for extension modules.

expall doesn't work, because of our use of identifiers in reserved namespaces,
e.g. _PG_init:

       expall
            Exports all global symbols, except imported symbols, unreferenced symbols defined in archive members, and symbols beginning with an underscore
            (_). You can export additional symbols by listing them in an export file or using the expfull option. This option does not affect symbols
            exported by the autoexp option.

However, there also is 'expfull' - IIRC that causes problems when used for
postgres, but appears to be fine for .so's.

So we could work around the xlc 12.1 issue with something like the attached
patch. It passes at some of the tests, with both 32 and 64bit xlc 12.1, will
have to wait a while to see more

I think it'd be considerably better to just not support xlc < 13.1 though.


This won't fix sungazer, that just needs the perl wrapper removed...

Greetings,

Andres Freund

Attachments:

  0001-wip.patch (text/x-diff, 0B) download

view thread (22+ messages)  latest in thread

Message-ID: <20220913182530.4yq35ralujjsv2k3@awork3.anarazel.de>
Permalink:  ../20220913182530.4yq35ralujjsv2k3@awork3.anarazel.de/
Also on:    postgresql.org/message-id/20220913182530.4yq35ralujjsv2k3@awork3.anarazel.de

 ·  · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: andres@anarazel.de, tgl@sss.pgh.pa.us, noah@leadboat.com, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: aix: No need to use mkldexport when we want to export all symbol
  In-Reply-To: <20220913182530.4yq35ralujjsv2k3@awork3.anarazel.de>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox