From: Andres Freund <andres@anarazel.de>
To: Michael Paquier <michael@paquier.xyz>
Cc: pgsql-hackers@lists.postgresql.org
Subject: Re: pg_upgrade test failure
Date: Mon, 19 Sep 2022 18:13:17 -0700
Message-ID: <20220920011317.24bbsihqwn5dg7fi@awork3.anarazel.de> (raw)
In-Reply-To: <YykSmXbGi08agCRq@paquier.xyz>
References: <E1oXuu7-0005bU-55@gemulon.postgresql.org>
<20220919213217.ptqfdlcc5idk5xup@awork3.anarazel.de>
<YykSmXbGi08agCRq@paquier.xyz>
Hi,
On 2022-09-20 10:08:41 +0900, Michael Paquier wrote:
> On Mon, Sep 19, 2022 at 02:32:17PM -0700, Andres Freund wrote:
> > I don't know if actually related to the commit below, but there've been a
> > lot of runs of the pg_upgrade tests in the meson branch, and this is the first
> > failure of this kind. Unfortunately the error seems to be transient -
> > rerunning the tests succeeded.
>
> This smells to me like a race condition in pg_upgrade (or even pg_ctl
> for SERVER_LOG_FILE) where the code still has handles on some of the
> files in the log/ subdirectory, causing its removal to not be able to
> finish happen.
I don't really see what'd race with what here? pg_upgrade has precise control
over what's happening here, no?
> If this proves to be rather easy to reproduce, giving
> a list of the files still present in this path would give a hint easy
> to follow. Does this reproduce with a good frequency?
I've only seen it once so far, but there haven't been many CI runs of the
meson branch since rebasing ontop of the last changes to pg_upgrade.
Greetings,
Andres Freund
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients from your mail client; the link fills in
the headers below: reply via email
Some clients, webmail especially, drop In-Reply-To and References from
a link, and the reply then starts a new thread: use the mbox below.
To: pgsql-committers@postgresql.org
Cc: andres@anarazel.de, michael@paquier.xyz, pgsql-hackers@lists.postgresql.org
Subject: Re: pg_upgrade test failure
In-Reply-To: <20220920011317.24bbsihqwn5dg7fi@awork3.anarazel.de>
References: <E1oXuu7-0005bU-55@gemulon.postgresql.org> <20220919213217.ptqfdlcc5idk5xup@awork3.anarazel.de> <YykSmXbGi08agCRq@paquier.xyz> <20220920011317.24bbsihqwn5dg7fi@awork3.anarazel.de>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox