pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Justin Pryzby <pryzby@telsasoft.com>
To: Robert Haas <rhaas@postgresql.org>
Cc: pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Increase width of RelFileNumbers from 32 bits to 56 bits.
Date: Tue, 27 Sep 2022 13:51:21 -0500
Message-ID: <20220927185121.GE6256@telsasoft.com> (raw)
In-Reply-To: <E1odERe-002H6A-LM@gemulon.postgresql.org>
References: <E1odERe-002H6A-LM@gemulon.postgresql.org>

This seems to be breaking cfbot:
https://cirrus-ci.com/github/postgresql-cfbot/postgresql

For example:
https://cirrus-ci.com/task/6720256776339456

Some other minor issues:

thais is only used during

=> this

+                       elog(ERROR, "unexpected relnumber " UINT64_FORMAT "that is bigger than nextRelFileNumber " UINT64_FORMAT,

=> there should be a space before "that".

+                                                "tli %u; prev tli %u; fpw %s; xid %u:%u; relfilenumber " UINT64_FORMAT ";oid %u; "

=> and a space before "oid"

+ * Parse relfilenumber value for an option.  If the parsing is successful,
+ * returns; if parsing fails, returns false.

returns *true;





view thread (4+ messages)  latest in thread

Message-ID: <20220927185121.GE6256@telsasoft.com>
Permalink:  ../20220927185121.GE6256@telsasoft.com/
Also on:    postgresql.org/message-id/20220927185121.GE6256@telsasoft.com

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: pryzby@telsasoft.com, rhaas@postgresql.org
  Subject: Re: pgsql: Increase width of RelFileNumbers from 32 bits to 56 bits.
  In-Reply-To: <20220927185121.GE6256@telsasoft.com>
  References: <E1odERe-002H6A-LM@gemulon.postgresql.org> <20220927185121.GE6256@telsasoft.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox