pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Andres Freund <andres@anarazel.de>
To: Thomas Munro <thomas.munro@gmail.com>
Cc: Justin Pryzby <pryzby@telsasoft.com>
Cc: Michael Paquier <michael@paquier.xyz>
Cc: pgsql-hackers@lists.postgresql.org, Nazir Bilal Yavuz <byavuz81@gmail.com>
Subject: Re: pg_upgrade test failure
Date: Tue, 6 Dec 2022 10:15:33 -0800
Message-ID: <20221206181533.pmcz75zbjgvnnzum@awork3.anarazel.de> (raw)
In-Reply-To: <CA+hUKGKFh-F2fz_18j3N6bKr966gmaJxV40T0qhDwhKkW+291g@mail.gmail.com>
References: <CA+hUKGJSkt3nx35uwpYX8D+cAZT38gk++btCp2Tz+uibH+Y1PA@mail.gmail.com>
	<CA+hUKG+H-q78LxD20UOVyJbP1_idyocj6va_v1TF4RnN9JZa+w@mail.gmail.com>
	<YzovdL3lqhmorvl0@paquier.xyz>
	<CA+hUKG+bk4KGwYT4JrZEdAgNdFm-c8ezTrxf-PacS-npQ_HdSw@mail.gmail.com>
	<YzqBIzMwoBiESmkk@paquier.xyz>
	<CA+hUKGKsdzw06c5nnb=KYG9GmvyykoVpJA_VR3k0r7cZOKcx6Q@mail.gmail.com>
	<Y04mN0ZLNzJywrad@paquier.xyz>
	<20221018043144.GF7745@telsasoft.com>
	<20221018162908.cb3n7tahtekypbkf@awork3.anarazel.de>
	<CA+hUKGKFh-F2fz_18j3N6bKr966gmaJxV40T0qhDwhKkW+291g@mail.gmail.com>

Hi,

On 2022-11-08 01:16:09 +1300, Thomas Munro wrote:
> So [1] on its own didn't fix this.  My next guess is that the attached
> might help.
> 
> Hmm.  Following Michael's clue that this might involve log files and
> pg_ctl, I noticed one thing: pg_ctl implements
> wait_for_postmaster_stop() by waiting for kill(pid, 0) to fail, and
> our kill emulation does CallNamedPipe().  If the server is in the
> process of exiting and the kernel is cleaning up all the handles we
> didn't close, is there any reason to expect the signal pipe to be
> closed after the log file?

What is our plan here? This afaict is the most common "false positive" for
cfbot in the last weeks.

E.g.:

https://api.cirrus-ci.com/v1/artifact/task/5462686092230656/testrun/build/testrun/pg_upgrade/002_pg_...
...
[00:02:58.761](93.859s) ok 10 - run of pg_upgrade for new instance
[00:02:58.808](0.047s) not ok 11 - pg_upgrade_output.d/ removed after pg_upgrade success
[00:02:58.815](0.007s) #   Failed test 'pg_upgrade_output.d/ removed after pg_upgrade success'
#   at C:/cirrus/src/bin/pg_upgrade/t/002_pg_upgrade.pl line 288.


Michael:

Why does 002_pg_upgrade.pl try to filter the list of files in
pg_upgrade_output.d for files ending in .log? And why does it print those
only after starting the new node?

How about moving the iteration through the pg_upgrade_output.d to before the
->start and printing all the files, but only slurp_file() if the filename ends
with *.log?

Minor nit: It seems off to quite so many copies of
  $newnode->data_dir . "/pg_upgrade_output.d"
particularly where the test defines $log_path, but then still builds
it from scratch after (line 304).

Greetings,

Andres Freund





view thread (35+ messages)  latest in thread

Message-ID: <20221206181533.pmcz75zbjgvnnzum@awork3.anarazel.de>
Permalink:  ../20221206181533.pmcz75zbjgvnnzum@awork3.anarazel.de/
Also on:    postgresql.org/message-id/20221206181533.pmcz75zbjgvnnzum@awork3.anarazel.de

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: andres@anarazel.de, thomas.munro@gmail.com, pryzby@telsasoft.com, michael@paquier.xyz, byavuz81@gmail.com
  Subject: Re: pg_upgrade test failure
  In-Reply-To: <20221206181533.pmcz75zbjgvnnzum@awork3.anarazel.de>
  References: <CA+hUKGJSkt3nx35uwpYX8D+cAZT38gk++btCp2Tz+uibH+Y1PA@mail.gmail.com> <CA+hUKG+H-q78LxD20UOVyJbP1_idyocj6va_v1TF4RnN9JZa+w@mail.gmail.com> <YzovdL3lqhmorvl0@paquier.xyz> <CA+hUKG+bk4KGwYT4JrZEdAgNdFm-c8ezTrxf-PacS-npQ_HdSw@mail.gmail.com> <YzqBIzMwoBiESmkk@paquier.xyz> <CA+hUKGKsdzw06c5nnb=KYG9GmvyykoVpJA_VR3k0r7cZOKcx6Q@mail.gmail.com> <Y04mN0ZLNzJywrad@paquier.xyz> <20221018043144.GF7745@telsasoft.com> <20221018162908.cb3n7tahtekypbkf@awork3.anarazel.de> <CA+hUKGKFh-F2fz_18j3N6bKr966gmaJxV40T0qhDwhKkW+291g@mail.gmail.com> <20221206181533.pmcz75zbjgvnnzum@awork3.anarazel.de>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox