From: Alvaro Herrera <alvherre@alvh.no-ip.org>
To: Peter Smith <smithpb2250@gmail.com>
Cc: Amit Kapila <akapila@postgresql.org>
Cc: pgsql-hackers@lists.postgresql.org
Subject: Re: pgsql: Doc: Explain about Column List feature.
Date: Mon, 19 Dec 2022 17:47:13 +0100
Message-ID: <20221219164713.ccnlvtkyj6lmshqq@alvherre.pgsql> (raw)
In-Reply-To: <20220915161142.6gtmmezq47nz37oi@alvherre.pgsql>
On 2022-Sep-15, Alvaro Herrera wrote:
> On 2022-Sep-15, Alvaro Herrera wrote:
>
> > Looking at the rendered docs again, I notice that section "31.4.5.
> > Combining Multiple Column Lists" is *only* the red-tinted Warning block.
> > That seems quite odd. I am tempted to remove the sect2 heading for that
> > one too.
>
> Pushed. I didn't modify this part; I spent too much time looking at it
> trying to figure out how to do it. I think this bit really belongs in
> the CREATE/ALTER docs rather than this chapter. But in order to support
> having a separate <para> for the restriction on combination, we need a
> separate <varlistentry> for the column_name parameter. So I'm going to
> edit that one and I'll throw this change in.
I figured out how to fix this one -- just remove the <sect2> tags, and
add a <title> tag to the <warning> box. The attached yields the
explanatory text in a separate box that doesn't have the silly
otherwise-empty section title. We add the 'id' that was in the sect2 to
the warning; with this, at the referencing end the full title is
rendered, which looks quite reasonable. I have attached screenshots of
both sides of this.
Compare the existing
https://www.postgresql.org/docs/15/logical-replication-col-lists.html#LOGICAL-REPLICATION-COL-LIST-C...
Unless there are objections, I'll get this pushed to 15 and master.
--
Álvaro Herrera Breisgau, Deutschland — https://www.EnterpriseDB.com/Attachments:
0001-Rework-warning-about-column-list-combining.patch (text/x-diff, 0B) download
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients from your mail client; the link fills in
the headers below: reply via email
Some clients, webmail especially, drop In-Reply-To and References from
a link, and the reply then starts a new thread: use the mbox below.
To: pgsql-committers@postgresql.org
Cc: alvherre@alvh.no-ip.org, smithpb2250@gmail.com, akapila@postgresql.org, pgsql-hackers@lists.postgresql.org
Subject: Re: pgsql: Doc: Explain about Column List feature.
In-Reply-To: <20221219164713.ccnlvtkyj6lmshqq@alvherre.pgsql>
References: <20220915161142.6gtmmezq47nz37oi@alvherre.pgsql> <20221219164713.ccnlvtkyj6lmshqq@alvherre.pgsql>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox