pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Andres Freund <andres@anarazel.de>
To: Peter Geoghegan <pg@bowt.ie>
Cc: Robert Haas <robertmhaas@gmail.com>
Cc: pgsql-hackers@postgresql.org
Subject: Re: pgsql: Delay commit status checks until freezing executes.
Date: Wed, 4 Jan 2023 10:41:10 -0800
Message-ID: <20230104184110.nrcfrkwrenihb5ne@awork3.anarazel.de> (raw)
In-Reply-To: <CAH2-Wz=pYBdTnPim1e_r+tXnz2_ERHfNUEHT6CABa3x6+4Pr+A@mail.gmail.com>
References: <CAH2-WzkM_uM3gArOPSkE=tn9to1tPicc0qM7mJUV=_BDamKamQ@mail.gmail.com>
	<CAH2-Wz=jYBAiDz1_vakdBUPseiau-Pexc9YtJ5yS7F80p_pqnw@mail.gmail.com>
	<20230104035636.hy5djyr2as4gbc4q@awork3.anarazel.de>
	<CAH2-WzmRTo_8_v=wkK3f08iVzuwVUQ3G=Ff00sFCK-Q+dPF2kg@mail.gmail.com>
	<20230104063325.32xq2gpnwlelhogo@awork3.anarazel.de>
	<CAH2-WzmYObiABaysh1SSNBgm0OPYm07DNzRq2vA1DgsOtrodFQ@mail.gmail.com>
	<20230104064740.6mnwcml6oqp3sxnr@awork3.anarazel.de>
	<CAH2-Wz=qKSEor8EHOzxhTDtxUacot0U=1hmnT=Rp8Q=OM4ggMw@mail.gmail.com>
	<CA+TgmobMdMGeBb=t8u5Z9++-V6cDfpJjSJtpAmUi=YEUPUA_mw@mail.gmail.com>
	<CAH2-Wz=pYBdTnPim1e_r+tXnz2_ERHfNUEHT6CABa3x6+4Pr+A@mail.gmail.com>

Hi,

On 2023-01-04 09:59:37 -0800, Peter Geoghegan wrote:
> On Wed, Jan 4, 2023 at 7:03 AM Robert Haas <robertmhaas@gmail.com> wrote:
> > and which functions return fully reliable results, I do
> > not think you should be committing your own patches in this area.
> 
> My mistake here had nothing to do with my own goals. I was trying to
> be diligent by hardening an existing check in passing, and it
> backfired.

When moving code around I strongly suggest to make as much of a diff to be
"move only". I find
  git diff --color-moved=dimmed-zebra --color-moved-ws=ignore-all-space
quite helpful for that.

Being able to see just the "really changed" lines makes it a lot easier to see
the crucial parts of a change.


> > There is probably a lot of potential benefit in improving the way this
> > stuff works, but there is also a heck of a lot of danger of creating
> > subtle data corrupting bugs that could easily take years to find.
> 
> It's currently possible for VACUUM to set the all-frozen bit while
> unsetting the all-visible bit, due to a race condition [1]. This is
> your long standing bug. So apparently nobody is qualified to commit
> patches in this area.

That's a non-sequitur. Bugs are a fact of programming.


> About a year ago, there was a massive argument over some earlier work
> in the same general area, by me. Being the subject of a pile-on on
> this mailing list is something that I find deeply upsetting and
> demoralizing. I just cannot take much more of it. At the same time,
> I've made quite an investment in the pending patches, and think that
> it's something that I have to see through.

I'm, genuinely!, sorry that you feel piled on. That wasn't, and isn't, my
goal. I think the area of code desperately needs work. I complained because I
didn't like the process and was afraid of the consequences and the perceived
need on my part to do post-commit reviews.

Greetings,

Andres Freund





view thread (24+ messages)  latest in thread

Message-ID: <20230104184110.nrcfrkwrenihb5ne@awork3.anarazel.de>
Permalink:  ../20230104184110.nrcfrkwrenihb5ne@awork3.anarazel.de/
Also on:    postgresql.org/message-id/20230104184110.nrcfrkwrenihb5ne@awork3.anarazel.de

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: andres@anarazel.de, pg@bowt.ie, robertmhaas@gmail.com, pgsql-hackers@postgresql.org
  Subject: Re: pgsql: Delay commit status checks until freezing executes.
  In-Reply-To: <20230104184110.nrcfrkwrenihb5ne@awork3.anarazel.de>
  References: <CAH2-WzkM_uM3gArOPSkE=tn9to1tPicc0qM7mJUV=_BDamKamQ@mail.gmail.com> <CAH2-Wz=jYBAiDz1_vakdBUPseiau-Pexc9YtJ5yS7F80p_pqnw@mail.gmail.com> <20230104035636.hy5djyr2as4gbc4q@awork3.anarazel.de> <CAH2-WzmRTo_8_v=wkK3f08iVzuwVUQ3G=Ff00sFCK-Q+dPF2kg@mail.gmail.com> <20230104063325.32xq2gpnwlelhogo@awork3.anarazel.de> <CAH2-WzmYObiABaysh1SSNBgm0OPYm07DNzRq2vA1DgsOtrodFQ@mail.gmail.com> <20230104064740.6mnwcml6oqp3sxnr@awork3.anarazel.de> <CAH2-Wz=qKSEor8EHOzxhTDtxUacot0U=1hmnT=Rp8Q=OM4ggMw@mail.gmail.com> <CA+TgmobMdMGeBb=t8u5Z9++-V6cDfpJjSJtpAmUi=YEUPUA_mw@mail.gmail.com> <CAH2-Wz=pYBdTnPim1e_r+tXnz2_ERHfNUEHT6CABa3x6+4Pr+A@mail.gmail.com> <20230104184110.nrcfrkwrenihb5ne@awork3.anarazel.de>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox