pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Andres Freund <andres@anarazel.de>
To: Peter Geoghegan <pg@bowt.ie>
Cc: pgsql-hackers@postgresql.org
Subject: Re: pgsql: Delay commit status checks until freezing executes.
Date: Sat, 7 Jan 2023 19:25:49 -0800
Message-ID: <20230108032549.xumh45fv6dicimmh@awork3.anarazel.de> (raw)
In-Reply-To: <CAH2-WzmK0eLKZM0vDwnQ0iDsooYrEgKWGo1QWshD0ds11cc79A@mail.gmail.com>
References: <CAH2-Wz=jYBAiDz1_vakdBUPseiau-Pexc9YtJ5yS7F80p_pqnw@mail.gmail.com>
	<20230104035636.hy5djyr2as4gbc4q@awork3.anarazel.de>
	<CAH2-WzmRTo_8_v=wkK3f08iVzuwVUQ3G=Ff00sFCK-Q+dPF2kg@mail.gmail.com>
	<20230104063325.32xq2gpnwlelhogo@awork3.anarazel.de>
	<CAH2-WzmYObiABaysh1SSNBgm0OPYm07DNzRq2vA1DgsOtrodFQ@mail.gmail.com>
	<20230104064740.6mnwcml6oqp3sxnr@awork3.anarazel.de>
	<CAH2-Wz=qKSEor8EHOzxhTDtxUacot0U=1hmnT=Rp8Q=OM4ggMw@mail.gmail.com>
	<CAH2-Wzn4bEEqgmaUQL3aJ73yM9gAeK-wE4ngi7kjRjLztb+P0w@mail.gmail.com>
	<20230107214756.fyrk735xkeetkkby@awork3.anarazel.de>
	<CAH2-WzmK0eLKZM0vDwnQ0iDsooYrEgKWGo1QWshD0ds11cc79A@mail.gmail.com>

Hi,

On 2023-01-07 15:41:29 -0800, Peter Geoghegan wrote:
> Do we need to do anything about this to the "pg_xact and pg_subtrans"
> section of the transam README?

Probably a good idea, although it doesn't neatly fit right now.


> Also, does amcheck's get_xid_status() need a reference to these rules?

Don't think so? Whad made you ask?


> FWIW, I found an existing comment about this rule in the call to
> TransactionIdAbortTree() from RecordTransactionAbort() -- which took
> me quite a while to find. So you might have been remembering that
> comment before.

Possible, my memory is vague enough that it's hard to be sure...

Greetings,

Andres Freund





view thread (24+ messages)  latest in thread

Message-ID: <20230108032549.xumh45fv6dicimmh@awork3.anarazel.de>
Permalink:  ../20230108032549.xumh45fv6dicimmh@awork3.anarazel.de/
Also on:    postgresql.org/message-id/20230108032549.xumh45fv6dicimmh@awork3.anarazel.de

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: andres@anarazel.de, pg@bowt.ie, pgsql-hackers@postgresql.org
  Subject: Re: pgsql: Delay commit status checks until freezing executes.
  In-Reply-To: <20230108032549.xumh45fv6dicimmh@awork3.anarazel.de>
  References: <CAH2-Wz=jYBAiDz1_vakdBUPseiau-Pexc9YtJ5yS7F80p_pqnw@mail.gmail.com> <20230104035636.hy5djyr2as4gbc4q@awork3.anarazel.de> <CAH2-WzmRTo_8_v=wkK3f08iVzuwVUQ3G=Ff00sFCK-Q+dPF2kg@mail.gmail.com> <20230104063325.32xq2gpnwlelhogo@awork3.anarazel.de> <CAH2-WzmYObiABaysh1SSNBgm0OPYm07DNzRq2vA1DgsOtrodFQ@mail.gmail.com> <20230104064740.6mnwcml6oqp3sxnr@awork3.anarazel.de> <CAH2-Wz=qKSEor8EHOzxhTDtxUacot0U=1hmnT=Rp8Q=OM4ggMw@mail.gmail.com> <CAH2-Wzn4bEEqgmaUQL3aJ73yM9gAeK-wE4ngi7kjRjLztb+P0w@mail.gmail.com> <20230107214756.fyrk735xkeetkkby@awork3.anarazel.de> <CAH2-WzmK0eLKZM0vDwnQ0iDsooYrEgKWGo1QWshD0ds11cc79A@mail.gmail.com> <20230108032549.xumh45fv6dicimmh@awork3.anarazel.de>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox