From: Justin Pryzby <pryzby@telsasoft.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Andres Freund <andres@anarazel.de>
Cc: pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Get rid of the "new" and "old" entries in a view's rangetable.
Date: Wed, 18 Jan 2023 14:40:06 -0600
Message-ID: <20230118204006.GB9837@telsasoft.com> (raw)
In-Reply-To: <3804194.1674074141@sss.pgh.pa.us>
References: <E1pID77-004KBV-9p@gemulon.postgresql.org>
<20230118195855.7yjc4mminmv7iyy5@awork3.anarazel.de>
<3787913.1674072518@sss.pgh.pa.us>
<20230118201451.f2dooawchsfy57qc@awork3.anarazel.de>
<3804194.1674074141@sss.pgh.pa.us>
On Wed, Jan 18, 2023 at 03:35:41PM -0500, Tom Lane wrote:
> Andres Freund <andres@anarazel.de> writes:
> > On 2023-01-18 15:08:38 -0500, Tom Lane wrote:
> >> Huh, I wonder why the cfbot never complained about that when
> >> it was testing this patch ... maybe it doesn't use win1252?
>
> > This is the same environment that cfbot is also using, so this is odd. And
> > cfbot has been failing on windows since the commit went into master:
>
> > https://cirrus-ci.com/github/postgresql-cfbot/postgresql/
>
> > So I guess something must have changed in the patch since then? I guess it
> > could be that something changed on the VM, but I don't think so...
>
> Hmmm ... the collate.windows.win1252 test did not exist at all before
> 3-Jan (bf03cfd16), while 1b4d280ea went in on 11-Jan. So perhaps the
> most plausible theory is that the cfbot didn't test this patch between
> those dates. It should certainly have noticed if it did run it ...
Looks like it failed the last 7 days
https://cirrus-ci.com/github/postgresql-cfbot/postgresql/commitfest/41/4048
I also saw that it failed in its previous incarnation, before the
revert, but didn't dig into it at that point.
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients from your mail client; the link fills in
the headers below: reply via email
Some clients, webmail especially, drop In-Reply-To and References from
a link, and the reply then starts a new thread: use the mbox below.
To: pgsql-committers@postgresql.org
Cc: pryzby@telsasoft.com, tgl@sss.pgh.pa.us, andres@anarazel.de
Subject: Re: pgsql: Get rid of the "new" and "old" entries in a view's rangetable.
In-Reply-To: <20230118204006.GB9837@telsasoft.com>
References: <E1pID77-004KBV-9p@gemulon.postgresql.org> <20230118195855.7yjc4mminmv7iyy5@awork3.anarazel.de> <3787913.1674072518@sss.pgh.pa.us> <20230118201451.f2dooawchsfy57qc@awork3.anarazel.de> <3804194.1674074141@sss.pgh.pa.us> <20230118204006.GB9837@telsasoft.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox