pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Andres Freund <andres@anarazel.de>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Michael Paquier <michael@paquier.xyz>
Cc: pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: instr_time: Represent time as an int64 on all platforms
Date: Tue, 24 Jan 2023 08:11:08 -0800
Message-ID: <20230124161108.b3bls2mc4kch6nve@awork3.anarazel.de> (raw)
In-Reply-To: <1540079.1674454854@sss.pgh.pa.us>
References: <E1pJ6NT-004jOH-DF@gemulon.postgresql.org>
	<Y84ZfhnTWJThOhUO@paquier.xyz>
	<1540079.1674454854@sss.pgh.pa.us>

Hi,

On 2023-01-23 01:20:54 -0500, Tom Lane wrote:
> I'm inclined to think that we should fix the plpython code to be rigorous
> about including everything else we need before including the Python
> headers.

I tried that, but I think it's hard with the current split of plpython
headers. Several of the plpy* headers, most significantly plpy_typeio.h,
include "postgres" headers. Which means that .c files can't include
plpy_typeio.h and still maintain the ordering of plpython headers coming last.

The only way I see that maintains the split of the plpython headers is to
institute the rule that plpy_* can't have any includes other than plpython.h,
and all their dependencies have to come from plpython.h.


I'll go and start a dedicated thread, this is too big a mess to discuss just
on -committers.

Greetings,

Andres Freund





view thread (7+ messages)

Message-ID: <20230124161108.b3bls2mc4kch6nve@awork3.anarazel.de>
Permalink:  ../20230124161108.b3bls2mc4kch6nve@awork3.anarazel.de/
Also on:    postgresql.org/message-id/20230124161108.b3bls2mc4kch6nve@awork3.anarazel.de

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: andres@anarazel.de, tgl@sss.pgh.pa.us, michael@paquier.xyz
  Subject: Re: pgsql: instr_time: Represent time as an int64 on all platforms
  In-Reply-To: <20230124161108.b3bls2mc4kch6nve@awork3.anarazel.de>
  References: <E1pJ6NT-004jOH-DF@gemulon.postgresql.org> <Y84ZfhnTWJThOhUO@paquier.xyz> <1540079.1674454854@sss.pgh.pa.us> <20230124161108.b3bls2mc4kch6nve@awork3.anarazel.de>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox