pg.ddx.io pgsql-committers@postgresql.org mailing list archive
help / color / mirror / Atom feedpgsql: Refactor to add pg_strcoll(), pg_strxfrm(), and variants.
4+ messages / 3 participants
[nested] [flat]
Commits from this thread:
2023-02-24 05fc551796 Silence compiler warnings introduced by d87d548cd0.
* pgsql: Refactor to add pg_strcoll(), pg_strxfrm(), and variants.
@ 2023-02-23 19:09 Jeff Davis <jdavis@postgresql.org>
0 siblings, 1 reply; 4+ messages in thread
From: Jeff Davis @ 2023-02-23 19:09 UTC (permalink / raw)
To: pgsql-committers@lists.postgresql.org
Refactor to add pg_strcoll(), pg_strxfrm(), and variants.
Offers a generally better separation of responsibilities for collation
code. Also, a step towards multi-lib ICU, which should be based on a
clean separation of the routines required for collation providers.
Callers with NUL-terminated strings should call pg_strcoll() or
pg_strxfrm(); callers with strings and their length should call the
variants pg_strncoll() or pg_strnxfrm().
Reviewed-by: Peter Eisentraut, Peter Geoghegan
Discussion: https://postgr.es/m/a581136455c940d7bd0ff482d3a2bd51af25a94f.camel%40j-davis.com
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/d87d548cd0304477413a73e9c1d148fb2d40b50d
Modified Files
--------------
src/backend/access/hash/hashfunc.c | 61 +--
src/backend/utils/adt/pg_locale.c | 769 ++++++++++++++++++++++++++++++++++++-
src/backend/utils/adt/varchar.c | 51 +--
src/backend/utils/adt/varlena.c | 368 +++---------------
src/include/utils/pg_locale.h | 13 +
5 files changed, 871 insertions(+), 391 deletions(-)
^ permalink raw reply [nested|flat] 4+ messages in thread
* Re: pgsql: Refactor to add pg_strcoll(), pg_strxfrm(), and variants.
@ 2023-02-24 00:20 Justin Pryzby <pryzby@telsasoft.com>
parent: Jeff Davis <jdavis@postgresql.org>
0 siblings, 1 reply; 4+ messages in thread
From: Justin Pryzby @ 2023-02-24 00:20 UTC (permalink / raw)
To: Jeff Davis <jdavis@postgresql.org>; +Cc: pgsql-hackers@lists.postgresql.org
These patches cause warnings under MSVC.
Of course my patch to improve CI by warning about compiler warnings is
the only one to notice.
https://cirrus-ci.com/task/6199582053367808
--
Justin
^ permalink raw reply [nested|flat] 4+ messages in thread
* Re: pgsql: Refactor to add pg_strcoll(), pg_strxfrm(), and variants.
@ 2023-02-24 00:56 Thomas Munro <thomas.munro@gmail.com>
parent: Justin Pryzby <pryzby@telsasoft.com>
0 siblings, 1 reply; 4+ messages in thread
From: Thomas Munro @ 2023-02-24 00:56 UTC (permalink / raw)
To: Justin Pryzby <pryzby@telsasoft.com>; +Cc: Jeff Davis <jdavis@postgresql.org>; pgsql-hackers@lists.postgresql.org
On Fri, Feb 24, 2023 at 1:20 PM Justin Pryzby <pryzby@telsasoft.com> wrote:
> These patches cause warnings under MSVC.
>
> Of course my patch to improve CI by warning about compiler warnings is
> the only one to notice.
>
> https://cirrus-ci.com/task/6199582053367808
It's a shame that it fails the whole Windows task, whereas for the
Unixen we don't do -Werror so you can still see if everything else is
OK, but then we check for errors in a separate task. I don't have any
ideas on how to achieve that, though.
FWIW my CI log scanner also noticed this problem
http://cfbot.cputube.org/highlights/compiler.html. Been wondering how
to bring that to the right people's attention. Perhaps by adding a
clickable ⚠ to the main page next to the item if any of these
"highlights" were detected; perhaps it should take you to a
per-submission history page with the highlights from each version.
^ permalink raw reply [nested|flat] 4+ messages in thread
* Re: pgsql: Refactor to add pg_strcoll(), pg_strxfrm(), and variants.
@ 2023-02-24 01:07 Justin Pryzby <pryzby@telsasoft.com>
parent: Thomas Munro <thomas.munro@gmail.com>
0 siblings, 0 replies; 4+ messages in thread
From: Justin Pryzby @ 2023-02-24 01:07 UTC (permalink / raw)
To: Thomas Munro <thomas.munro@gmail.com>; +Cc: Jeff Davis <jdavis@postgresql.org>; pgsql-hackers@lists.postgresql.org
On Fri, Feb 24, 2023 at 01:56:05PM +1300, Thomas Munro wrote:
> On Fri, Feb 24, 2023 at 1:20 PM Justin Pryzby <pryzby@telsasoft.com> wrote:
> > These patches cause warnings under MSVC.
> >
> > Of course my patch to improve CI by warning about compiler warnings is
> > the only one to notice.
> >
> > https://cirrus-ci.com/task/6199582053367808
>
> It's a shame that it fails the whole Windows task, whereas for the
> Unixen we don't do -Werror so you can still see if everything else is
> OK, but then we check for errors in a separate task. I don't have any
> ideas on how to achieve that, though.
My patch isn't very pretty, but you can see that runs all the tests
before grepping for warnings, rather than failing during compilation as
you said.
IMO the compiler warnings task is separate not only "to avoid failing
the whole task during compilation", but because it's compiled with
optimization. Which is 1) needed to allow some warnings to be warned
about; and, 2) harmful to enable during the "check-world" tests, since
it makes backtraces less accurate.
--
Justin
^ permalink raw reply [nested|flat] 4+ messages in thread
end of thread, other threads:[~2023-02-24 01:07 UTC | newest]
Thread overview: 4+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2023-02-23 19:09 pgsql: Refactor to add pg_strcoll(), pg_strxfrm(), and variants. Jeff Davis <jdavis@postgresql.org>
2023-02-24 00:20 ` Justin Pryzby <pryzby@telsasoft.com>
2023-02-24 00:56 ` Thomas Munro <thomas.munro@gmail.com>
2023-02-24 01:07 ` Justin Pryzby <pryzby@telsasoft.com>
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox