From: Justin Pryzby <pryzby@telsasoft.com>
To: Thomas Munro <thomas.munro@gmail.com>
Cc: Jeff Davis <jdavis@postgresql.org>
Cc: pgsql-hackers@lists.postgresql.org
Subject: Re: pgsql: Refactor to add pg_strcoll(), pg_strxfrm(), and variants.
Date: Thu, 23 Feb 2023 19:07:16 -0600
Message-ID: <20230224010715.GR1653@telsasoft.com> (raw)
In-Reply-To: <CA+hUKGJvJe0kjxXJ8b2mEibHFX2q69rJTQLq-WxiyW-JvErFmQ@mail.gmail.com>
References: <E1pVGxp-000Ld1-LJ@gemulon.postgresql.org>
<20230224002029.GQ1653@telsasoft.com>
<CA+hUKGJvJe0kjxXJ8b2mEibHFX2q69rJTQLq-WxiyW-JvErFmQ@mail.gmail.com>
On Fri, Feb 24, 2023 at 01:56:05PM +1300, Thomas Munro wrote:
> On Fri, Feb 24, 2023 at 1:20 PM Justin Pryzby <pryzby@telsasoft.com> wrote:
> > These patches cause warnings under MSVC.
> >
> > Of course my patch to improve CI by warning about compiler warnings is
> > the only one to notice.
> >
> > https://cirrus-ci.com/task/6199582053367808
>
> It's a shame that it fails the whole Windows task, whereas for the
> Unixen we don't do -Werror so you can still see if everything else is
> OK, but then we check for errors in a separate task. I don't have any
> ideas on how to achieve that, though.
My patch isn't very pretty, but you can see that runs all the tests
before grepping for warnings, rather than failing during compilation as
you said.
IMO the compiler warnings task is separate not only "to avoid failing
the whole task during compilation", but because it's compiled with
optimization. Which is 1) needed to allow some warnings to be warned
about; and, 2) harmful to enable during the "check-world" tests, since
it makes backtraces less accurate.
--
Justin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: pryzby@telsasoft.com, thomas.munro@gmail.com, jdavis@postgresql.org, pgsql-hackers@lists.postgresql.org
Subject: Re: pgsql: Refactor to add pg_strcoll(), pg_strxfrm(), and variants.
In-Reply-To: <20230224010715.GR1653@telsasoft.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox