pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Jeff Davis <jdavis@postgresql.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Refactor to add pg_strcoll(), pg_strxfrm(), and variants.
Date: Thu, 23 Feb 2023 19:09:10 +0000
Message-ID: <E1pVGxp-000Ld1-LJ@gemulon.postgresql.org> (raw)

Refactor to add pg_strcoll(), pg_strxfrm(), and variants.

Offers a generally better separation of responsibilities for collation
code. Also, a step towards multi-lib ICU, which should be based on a
clean separation of the routines required for collation providers.

Callers with NUL-terminated strings should call pg_strcoll() or
pg_strxfrm(); callers with strings and their length should call the
variants pg_strncoll() or pg_strnxfrm().

Reviewed-by: Peter Eisentraut, Peter Geoghegan
Discussion: https://postgr.es/m/a581136455c940d7bd0ff482d3a2bd51af25a94f.camel%40j-davis.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/d87d548cd0304477413a73e9c1d148fb2d40b50d

Modified Files
--------------
src/backend/access/hash/hashfunc.c |  61 +--
src/backend/utils/adt/pg_locale.c  | 769 ++++++++++++++++++++++++++++++++++++-
src/backend/utils/adt/varchar.c    |  51 +--
src/backend/utils/adt/varlena.c    | 368 +++---------------
src/include/utils/pg_locale.h      |  13 +
5 files changed, 871 insertions(+), 391 deletions(-)



view thread (4+ messages)  latest in thread

Message-ID: <E1pVGxp-000Ld1-LJ@gemulon.postgresql.org>
Permalink:  ../E1pVGxp-000Ld1-LJ@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1pVGxp-000Ld1-LJ@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: jdavis@postgresql.org, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: Refactor to add pg_strcoll(), pg_strxfrm(), and variants.
  In-Reply-To: <E1pVGxp-000Ld1-LJ@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox