From: Andres Freund <andres@anarazel.de>
To: Justin Pryzby <pryzby@telsasoft.com>
Cc: pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: meson: add install-{quiet, world} targets
Date: Sat, 25 Mar 2023 11:20:55 -0700
Message-ID: <20230325182055.7e5tekype2ofn3kx@awork3.anarazel.de> (raw)
In-Reply-To: <ZB8331v5IhUA/pNu@telsasoft.com>
References: <E1pfZ4m-0055rk-1w@gemulon.postgresql.org>
<ZB80pMTApGk+BcvT@telsasoft.com>
<20230325180310.o6drykb3uz4u4x4r@awork3.anarazel.de>
<ZB8331v5IhUA/pNu@telsasoft.com>
Hi,
On 2023-03-25 13:05:19 -0500, Justin Pryzby wrote:
> On Sat, Mar 25, 2023 at 11:03:10AM -0700, Andres Freund wrote:
> > Hi,
> >
> > On 2023-03-25 12:51:32 -0500, Justin Pryzby wrote:
> > > On Fri, Mar 24, 2023 at 04:30:52AM +0000, Andres Freund wrote:
> > > > meson: add install-{quiet, world} targets
> > >
> > > if docs.length() == 0
> > > run_target('docs', command: [missing, 'xsltproc'])
> > > else
> > > alias_target('docs', docs)
> > > + alias_target('install-docs', installdocs)
> > > endif
> > >
> > > This fails to handle installdocs.length() == 0
> >
> > You mean in the sense of causing a failure in meson, or not providing the
> > install-docs target? For the latter: Yea. I wasn't sure what the behaviour
>
> The former, I guess. I was going to look into the windows python header
> warnings, but the configure step failed like:
>
> [17:27:16.781] doc\src\sgml\meson.build:327:2: ERROR: alias_target takes at least 2 arguments, but got 1.
Huh - I thought that wouldn't be possible, because docs would also be empty in
that case. But it's not, because I added postgres-full.xml to docs (probably
so you can see docs xml validity issues with just xmllint available). So
"your" error happens if just xmllint, but not xsltproc is available.
I think the easiest "fix" might be to just define install-docs to also include
docs - that way install-docs at least checks the validity of xml, even if we
can't build any docs.
Greetings,
Andres Freund
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients from your mail client; the link fills in
the headers below: reply via email
Some clients, webmail especially, drop In-Reply-To and References from
a link, and the reply then starts a new thread: use the mbox below.
To: pgsql-committers@postgresql.org
Cc: andres@anarazel.de, pryzby@telsasoft.com
Subject: Re: pgsql: meson: add install-{quiet, world} targets
In-Reply-To: <20230325182055.7e5tekype2ofn3kx@awork3.anarazel.de>
References: <E1pfZ4m-0055rk-1w@gemulon.postgresql.org> <ZB80pMTApGk+BcvT@telsasoft.com> <20230325180310.o6drykb3uz4u4x4r@awork3.anarazel.de> <ZB8331v5IhUA/pNu@telsasoft.com> <20230325182055.7e5tekype2ofn3kx@awork3.anarazel.de>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox