pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Kyotaro Horiguchi <horikyota.ntt@gmail.com>
To: drowley@postgresql.org
Cc: pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Add VACUUM/ANALYZE BUFFER_USAGE_LIMIT option
Date: Tue, 11 Apr 2023 12:02:38 +0900 (JST)
Message-ID: <20230411.120238.1102085277698061857.horikyota.ntt@gmail.com> (raw)
In-Reply-To: <20230411.102335.1643720544536884844.horikyota.ntt@gmail.com>
References: <E1pkZE9-001lHb-Cm@gemulon.postgresql.org>
	<20230411.102335.1643720544536884844.horikyota.ntt@gmail.com>

I apologize for writing mails in such a sporadic manner..

At Tue, 11 Apr 2023 10:23:35 +0900 (JST), Kyotaro Horiguchi <horikyota.ntt@gmail.com> wrote in 
> Hello.
> 
> > Add VACUUM/ANALYZE BUFFER_USAGE_LIMIT option
> 
> This commit added the following error message.
> 
> >		 errmsg("value: \"%s\": is invalid for buffer_usage_limit",
> 
> It looks as the follows on terminal.
> 
> postgres=# vacuum (buffer_usage_limit 'x');
> ERROR:  value: "x": is invalid for buffer_usage_limit
> 
> I'm not sure why the message has two colons.  [1] talks about the
> message but doesn't really explain the reason for this.
> 
> [1] https://www.postgresql.org/message-id/CAApHDvqs%2BFcw9Yrn4ORCAX0xKK1-SiCC0w1j7Dhg%3DG9hrvag7g%40mail...

vacuum.c:198
>      if (opt->arg == NULL)
>      {
>        ereport(ERROR,
>            (errcode(ERRCODE_SYNTAX_ERROR),
>             errmsg("buffer_usage_limit option requires a valid value"),
>             parser_errposition(pstate, opt->location)));

> postgres=# vacuum (buffer_usage_limit);
> ERROR:  buffer_usage_limit requires a valid value

The error message doesn't really make much sense to me.  In the same
context, most of the code seems to use ("%s requires a parameter",
buffer_usage_limit) without "valid".

vacuum.c:347
>		 errmsg("BUFFER_USAGE_LIMIT cannot be specified for VACUUM FULL")));

It seems like that the vacuum options are usually spelled in uppercase
at least for vacuum and analyze. In any case, shouldn't we need to
unify them in a certain area?  (For example, command options for
CREATE SUBSCRIPTION is shown in lowercase in the documentation. But,
I'm not exactly sure what we should do about it.)

regards.

-- 
Kyotaro Horiguchi
NTT Open Source Software Center





view thread (7+ messages)  latest in thread

Message-ID: <20230411.120238.1102085277698061857.horikyota.ntt@gmail.com>
Permalink:  ../20230411.120238.1102085277698061857.horikyota.ntt@gmail.com/
Also on:    postgresql.org/message-id/20230411.120238.1102085277698061857.horikyota.ntt@gmail.com

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: horikyota.ntt@gmail.com, drowley@postgresql.org
  Subject: Re: pgsql: Add VACUUM/ANALYZE BUFFER_USAGE_LIMIT option
  In-Reply-To: <20230411.120238.1102085277698061857.horikyota.ntt@gmail.com>
  References: <E1pkZE9-001lHb-Cm@gemulon.postgresql.org> <20230411.102335.1643720544536884844.horikyota.ntt@gmail.com> <20230411.120238.1102085277698061857.horikyota.ntt@gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox