pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Kyotaro Horiguchi <horikyota.ntt@gmail.com>
To: andres@anarazel.de
Cc: pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Allow logical decoding on standbys
Date: Tue, 11 Apr 2023 12:02:53 +0900 (JST)
Message-ID: <20230411.120253.579856734111967616.horikyota.ntt@gmail.com> (raw)
In-Reply-To: <E1pl4qQ-0021HA-Bw@gemulon.postgresql.org>
References: <E1pl4qQ-0021HA-Bw@gemulon.postgresql.org>

> Allow logical decoding on standbys

This adds the following error message.

+	errmsg("logical decoding on a standby requires wal_level to be at least logical on the primary")));

We alredy have a nearly identical message as follows.

> errmsg("logical decoding requires wal_level >= logical")));

And we used to writte this kind of conditions, like "wal_level >=
logical", using a mathematical operator. Don't we need to unify them?

And, a nearby commit addds the following message.

+			appendStringInfo(&err_detail, _("Logical decoding on standby requires wal_level to be at least logical on the primary server"));

This is omitting the indefinite article before "standby". I'm not sure
what to do about it but feel like we don't need it here.

inline patch 1: src/backend/replication/logical/decode.c, src/backend/replication/logical/logical.c (+2/-2 lines) download inline-1.patchdiff --git a/src/backend/replication/logical/decode.c b/src/backend/replication/logical/decode.c index 5508cc2177..beef399b42 100644 --- a/src/backend/replication/logical/decode.c +++ b/src/backend/replication/logical/decode.c @@ -177,7 +177,7 @@ xlog_decode(LogicalDecodingContext *ctx, XLogRecordBuffer *buf) Assert(RecoveryInProgress()); ereport(ERROR, (errcode(ERRCODE_OBJECT_NOT_IN_PREREQUISITE_STATE), - errmsg("logical decoding on a standby requires wal_level to be at least logical on the primary"))); + errmsg("logical decoding on standby requires wal_level >= logical on the primary"))); } break; } diff --git a/src/backend/replication/logical/logical.c b/src/backend/replication/logical/logical.c index 82dae95080..7e1f677f7a 100644 --- a/src/backend/replication/logical/logical.c +++ b/src/backend/replication/logical/logical.c @@ -137,7 +137,7 @@ CheckLogicalDecodingRequirements(void) if (GetActiveWalLevelOnStandby() < WAL_LEVEL_LOGICAL) ereport(ERROR, (errcode(ERRCODE_OBJECT_NOT_IN_PREREQUISITE_STATE), - errmsg("logical decoding on a standby requires wal_level to be at least logical on the primary"))); + errmsg("logical decoding on standby requires wal_level >= logical on the primary"))); } }
regards. -- Kyotaro Horiguchi NTT Open Source Software Center

view thread (8+ messages)  latest in thread

Message-ID: <20230411.120253.579856734111967616.horikyota.ntt@gmail.com>
Permalink:  ../20230411.120253.579856734111967616.horikyota.ntt@gmail.com/
Also on:    postgresql.org/message-id/20230411.120253.579856734111967616.horikyota.ntt@gmail.com

 ·  · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: horikyota.ntt@gmail.com, andres@anarazel.de, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: Allow logical decoding on standbys
  In-Reply-To: <20230411.120253.579856734111967616.horikyota.ntt@gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox