From: Kyotaro Horiguchi <horikyota.ntt@gmail.com>
To: robertmhaas@gmail.com
Cc: andres@anarazel.de
Cc: pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Allow logical decoding on standbys
Date: Fri, 14 Apr 2023 16:36:39 +0900 (JST)
Message-ID: <20230414.163639.1769329243014370943.horikyota.ntt@gmail.com> (raw)
In-Reply-To: <CA+TgmoZcwyuoVcTERFDoQHO40gcYKMt+J=wJeVUpXf2RHMUpWA@mail.gmail.com>
References: <20230411.120253.579856734111967616.horikyota.ntt@gmail.com>
<20230412174244.6njadz4uoiez3l74@awork3.anarazel.de>
<CA+TgmoZcwyuoVcTERFDoQHO40gcYKMt+J=wJeVUpXf2RHMUpWA@mail.gmail.com>
At Thu, 13 Apr 2023 12:07:19 -0400, Robert Haas <robertmhaas@gmail.com> wrote in
> On Wed, Apr 12, 2023 at 1:43=E2=80=AFPM Andres Freund <andres@anarazel.de> =
> wrote:
> > > And, a nearby commit addds the following message.
> > >
> > > + appendStringInfo(&err_detail, _("Logical decoding=
> on standby requires wal_level to be at least logical on the primary server=
> "));
> > >
> > > This is omitting the indefinite article before "standby". I'm not sure
> > > what to do about it but feel like we don't need it here.
> >
> > I don't think we need it either, but I'm not a native speaker.
>
> I am a native speaker of English and I think it is not required here.
> If we were going to add an article, I think we would want an
> indefinite one ("a standby") not a definite one ("the standby")
> because we're talking about a general truism, not a situation that
> pertains to one specific server. However, I don't think we should add
> that because the current phrasing is more consistent with our general
> practice. It's not the way you would actually talk, but it the way
> that people often write error messages. For example, we say "file not
> found" not "the file was not found," and nobody gets upset or confused
> by that.
Thaks for the clarification!
regards.
--
Kyotaro Horiguchi
NTT Open Source Software Center
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients from your mail client; the link fills in
the headers below: reply via email
Some clients, webmail especially, drop In-Reply-To and References from
a link, and the reply then starts a new thread: use the mbox below.
To: pgsql-committers@postgresql.org
Cc: horikyota.ntt@gmail.com, robertmhaas@gmail.com, andres@anarazel.de
Subject: Re: pgsql: Allow logical decoding on standbys
In-Reply-To: <20230414.163639.1769329243014370943.horikyota.ntt@gmail.com>
References: <20230411.120253.579856734111967616.horikyota.ntt@gmail.com> <20230412174244.6njadz4uoiez3l74@awork3.anarazel.de> <CA+TgmoZcwyuoVcTERFDoQHO40gcYKMt+J=wJeVUpXf2RHMUpWA@mail.gmail.com> <20230414.163639.1769329243014370943.horikyota.ntt@gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox