From: Kyotaro Horiguchi <horikyota.ntt@gmail.com>
To: andres@anarazel.de
Cc: pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Support invalidating replication slots due to horizon and wal_le
Date: Tue, 11 Apr 2023 12:03:01 +0900 (JST)
Message-ID: <20230411.120301.93333867350615278.horikyota.ntt@gmail.com> (raw)
In-Reply-To: <E1pl1l7-001zjq-RM@gemulon.postgresql.org>
References: <E1pl1l7-001zjq-RM@gemulon.postgresql.org>
> Support invalidating replication slots due to horizon and wal_level
This adds the following message.
+ appendStringInfo(&err_detail, _("Logical decoding on standby requires wal_level to be at least logical on the primary server"));
This message is missing a period at the end.
regards.
inline patch 1: src/backend/replication/slot.c (+1/-1 lines) download inline-1.patchdiff --git a/src/backend/replication/slot.c b/src/backend/replication/slot.cindex 41848f0ac6..e73fd2d13b 100644--- a/src/backend/replication/slot.c+++ b/src/backend/replication/slot.c@@ -1274,7 +1274,7 @@ ReportSlotInvalidation(ReplicationSlotInvalidationCause cause,
break;
case RS_INVAL_WAL_LEVEL:
- appendStringInfo(&err_detail, _("Logical decoding on standby requires wal_level to be at least logical on the primary server"));+ appendStringInfo(&err_detail, _("Logical decoding on standby requires wal_level to be at least logical on the primary server."));
break;
case RS_INVAL_NONE:
pg_unreachable();
--
Kyotaro Horiguchi
NTT Open Source Software Center
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: horikyota.ntt@gmail.com, andres@anarazel.de, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Support invalidating replication slots due to horizon and wal_le
In-Reply-To: <20230411.120301.93333867350615278.horikyota.ntt@gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox