pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Andres Freund <andres@anarazel.de>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Integrate pg_bsd_indent into our build/test infrastructure.
Date: Tue, 11 Jul 2023 16:33:07 -0700
Message-ID: <20230711233307.hu4wetabjm5f7ver@awork3.anarazel.de> (raw)
In-Reply-To: <E1pRG3X-000mLU-80@gemulon.postgresql.org>
References: <E1pRG3X-000mLU-80@gemulon.postgresql.org>

Hi,

On 2023-02-12 17:22:27 +0000, Tom Lane wrote:
> Integrate pg_bsd_indent into our build/test infrastructure.
...
> src/tools/pg_bsd_indent/t/001_pg_bsd_indent.pl | 53 ++++++++++++++++++++++

I just saw a random failure of exactly one of the test in CI (when testing a
new meson version, oddly enough):

# Running: diff -upd C:/cirrus/src/tools/pg_bsd_indent/tests/elsecomment.0.stdout elsecomment.out
[21:41:17.438](0.076s) not ok 13 - pg_bsd_indent output matches for elsecomment
[21:41:17.438](0.000s) #   Failed test 'pg_bsd_indent output matches for elsecomment'
#   at C:/cirrus/src/tools/pg_bsd_indent/t/001_pg_bsd_indent.pl line 50.


And subsequently noticed that CI currently doesn't collect the tests.diff
file, so I don't know why that failed. CI currently collects all *.diffs
files, I don't really want it to also collect all .diff files, since most of
the time that would be redundant with the .diffs file.

Would you mind if I rename the output file to test.diffs? That seems to make
more sense than explicitly capturing this file...

Greetings,

Andres Freund





view thread (4+ messages)  latest in thread

Message-ID: <20230711233307.hu4wetabjm5f7ver@awork3.anarazel.de>
Permalink:  ../20230711233307.hu4wetabjm5f7ver@awork3.anarazel.de/
Also on:    postgresql.org/message-id/20230711233307.hu4wetabjm5f7ver@awork3.anarazel.de

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: andres@anarazel.de, tgl@sss.pgh.pa.us, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: Integrate pg_bsd_indent into our build/test infrastructure.
  In-Reply-To: <20230711233307.hu4wetabjm5f7ver@awork3.anarazel.de>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox