pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Noah Misch <noah@leadboat.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Peter Geoghegan <pg@bowt.ie>
Cc: pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Dissociate btequalimage() from interval_ops, ending its deduplic
Date: Sat, 14 Oct 2023 17:03:58 -0700
Message-ID: <20231015000358.2d@rfd.leadboat.com> (raw)
In-Reply-To: <1974777.1697327121@sss.pgh.pa.us>
References: <E1qroAX-000arw-0A@gemulon.postgresql.org>
	<1974777.1697327121@sss.pgh.pa.us>

On Sat, Oct 14, 2023 at 07:45:21PM -0400, Tom Lane wrote:
> Noah Misch <noah@leadboat.com> writes:
> > ... This fix makes interval_ops simply omit the support function,
> > like numeric_ops does.  Back-pack to v13, where btequalimage() first
> > appeared.  In back branches, for the benefit of old catalog content,
> > btequalimage() code will return false for type "interval".  Going
> > forward, back-branch initdb will include the catalog change.
> 
> Hmm, I'm not sure that that last is a good idea.  The upshot of this
> (because of the opr_sanity.out change) is that "make installcheck"
> will fail against existing back-branch installations.  That seems
> more likely to cause problems/confusion than the alternative of just
> depending on the code change.

I'm way more worried about amcheck failing on all those indexes than I am
about someone who needs to tweak their installcheck rig.  I accepted the
former as the least-bad option, but if any area needs more thought, I feel
that's the area.





view thread (13+ messages)  latest in thread

Message-ID: <20231015000358.2d@rfd.leadboat.com>
Permalink:  ../20231015000358.2d@rfd.leadboat.com/
Also on:    postgresql.org/message-id/20231015000358.2d@rfd.leadboat.com

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: noah@leadboat.com, tgl@sss.pgh.pa.us, pg@bowt.ie, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: Dissociate btequalimage() from interval_ops, ending its deduplic
  In-Reply-To: <20231015000358.2d@rfd.leadboat.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox