From: Andres Freund <andres@anarazel.de>
To: Melanie Plageman <melanieplageman@gmail.com>
Cc: pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Reduce branches in heapgetpage()'s per-tuple loop
Date: Sun, 7 Apr 2024 10:26:15 -0700
Message-ID: <20240407172615.cocrsvboqm3ttqe4@awork3.anarazel.de> (raw)
In-Reply-To: <CAAKRu_ZXtWKCE-7XC5pJchUXRe9kQZmgX-NQjnc3BnO=nHRhrA@mail.gmail.com>
References: <E1rtMxq-000wGZ-6c@gemulon.postgresql.org>
<CAAKRu_ZXtWKCE-7XC5pJchUXRe9kQZmgX-NQjnc3BnO=nHRhrA@mail.gmail.com>
Hi,
On 2024-04-07 09:14:57 -0400, Melanie Plageman wrote:
> On Sun, Apr 7, 2024 at 3:29 AM Andres Freund <andres@anarazel.de> wrote:
> >
> > Reduce branches in heapgetpage()'s per-tuple loop
> >
> > Until now, heapgetpage()'s loop over all tuples performed some conditional
> > checks for each tuple, even though condition did not change across the loop.
>
> I haven't reviewed exactly what this does, but heapgetpage() was
> removed (or split into two functions, rather) in 44086b097537, so I
> find the naming of this function, or, at least the comments, commit
> message and description a bit confusing.
Oops. That name was so ingrained in my head that despite looking over these
lines quite a few times, I couldn't spot that.
Will send an update to the thread.
Greetings,
Andres Freund
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: andres@anarazel.de, melanieplageman@gmail.com, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Reduce branches in heapgetpage()'s per-tuple loop
In-Reply-To: <20240407172615.cocrsvboqm3ttqe4@awork3.anarazel.de>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox