From: Kyotaro Horiguchi <horikyota.ntt@gmail.com>
To: heikki.linnakangas@iki.fi
Cc: pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Enhance libpq encryption negotiation tests with new GUC
Date: Mon, 08 Apr 2024 15:40:10 +0900 (JST)
Message-ID: <20240408.154010.1170771365226258348.horikyota.ntt@gmail.com> (raw)
In-Reply-To: <E1rtcH1-0012Sl-IJ@gemulon.postgresql.org>
References: <E1rtcH1-0012Sl-IJ@gemulon.postgresql.org>
At Sun, 07 Apr 2024 23:50:08 +0000, Heikki Linnakangas <heikki.linnakangas@iki.fi> wrote in
> Enhance libpq encryption negotiation tests with new GUC
This commit adds the following messages:
> gettext_noop("Log details of pre-authentication connection handshake."),
Similar to a nearby commit, other messages with a similar context use
the phrase "Logs <something>". Wouldn't it be better to align this
message with existing ones?
inline patch 1: src/backend/utils/misc/guc_tables.c (+1/-1 lines) download inline-1.patchdiff --git a/src/backend/utils/misc/guc_tables.c b/src/backend/utils/misc/guc_tables.cindex 83e3a59d7e..4584829992 100644--- a/src/backend/utils/misc/guc_tables.c+++ b/src/backend/utils/misc/guc_tables.c@@ -1227,7 +1227,7 @@ struct config_bool ConfigureNamesBool[] =
},
{
{"trace_connection_negotiation", PGC_POSTMASTER, DEVELOPER_OPTIONS,
- gettext_noop("Log details of pre-authentication connection handshake."),+ gettext_noop("Logs details of pre-authentication connection handshake."),
NULL,
GUC_NOT_IN_SAMPLE
},
regards
--
Kyotaro Horiguchi
NTT Open Source Software Center
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: horikyota.ntt@gmail.com, heikki.linnakangas@iki.fi, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Enhance libpq encryption negotiation tests with new GUC
In-Reply-To: <20240408.154010.1170771365226258348.horikyota.ntt@gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox