From: Heikki Linnakangas <hlinnaka@iki.fi>
To: Kyotaro Horiguchi <horikyota.ntt@gmail.com>
Cc: pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Enhance libpq encryption negotiation tests with new GUC
Date: Mon, 8 Apr 2024 12:15:05 +0300
Message-ID: <a0f25fff-2521-4ef6-a58c-e29bd36e67c5@iki.fi> (raw)
In-Reply-To: <20240408.154010.1170771365226258348.horikyota.ntt@gmail.com>
References: <E1rtcH1-0012Sl-IJ@gemulon.postgresql.org>
<20240408.154010.1170771365226258348.horikyota.ntt@gmail.com>
On 08/04/2024 09:40, Kyotaro Horiguchi wrote:
> At Sun, 07 Apr 2024 23:50:08 +0000, Heikki Linnakangas <heikki.linnakangas@iki.fi> wrote in
>> Enhance libpq encryption negotiation tests with new GUC
>
> This commit adds the following messages:
>
>> gettext_noop("Log details of pre-authentication connection handshake."),
>
> Similar to a nearby commit, other messages with a similar context use
> the phrase "Logs <something>". Wouldn't it be better to align this
> message with existing ones?
>
> diff --git a/src/backend/utils/misc/guc_tables.c b/src/backend/utils/misc/guc_tables.c
> index 83e3a59d7e..4584829992 100644
> --- a/src/backend/utils/misc/guc_tables.c
> +++ b/src/backend/utils/misc/guc_tables.c
> @@ -1227,7 +1227,7 @@ struct config_bool ConfigureNamesBool[] =
> },
> {
> {"trace_connection_negotiation", PGC_POSTMASTER, DEVELOPER_OPTIONS,
> - gettext_noop("Log details of pre-authentication connection handshake."),
> + gettext_noop("Logs details of pre-authentication connection handshake."),
> NULL,
> GUC_NOT_IN_SAMPLE
> },
We're not very consistent about it, there's also:
log_temp_files: Log the use of temporary files larger than this number
of kilobytes.
trace_syncscan: Generate debugging output for synchronized scanning.
trace_sort: Emit information about resource usage in sorting.
backtrace_functions: Log backtrace for errors in these functions.
backtrace_on_internal_error: Log backtrace for any error with error code
XX000 (internal error).
But I agree the "Logs ..." phrasing is more common, so committed.
--
Heikki Linnakangas
Neon (https://neon.tech)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: hlinnaka@iki.fi, horikyota.ntt@gmail.com, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Enhance libpq encryption negotiation tests with new GUC
In-Reply-To: <a0f25fff-2521-4ef6-a58c-e29bd36e67c5@iki.fi>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox