From: Noah Misch <noah@leadboat.com>
To: Andrew Dunstan <andrew@dunslane.net>
Cc: pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Skip some permissions checks on Cygwin
Date: Sun, 23 Jun 2024 18:03:11 -0700
Message-ID: <20240624010311.0b.nmisch@google.com> (raw)
In-Reply-To: <E1sHjJc-001KCN-H6@gemulon.postgresql.org>
References: <E1sHjJc-001KCN-H6@gemulon.postgresql.org>
On Thu, Jun 13, 2024 at 12:12:29PM +0000, Andrew Dunstan wrote:
> Skip some permissions checks on Cygwin
>
> These are checks that are already skipped on other Windows systems.
> skip "unix-style permissions not supported on Windows", 2
> - if ($windows_os);
> + if ($windows_os || $Config::Config{osname} eq 'cygwin');
> - skip "group access not supported on Windows", 3 if ($windows_os);
> + skip "group access not supported on Windows", 3
> + if ($windows_os || $Config::Config{osname} eq 'cygwin');
Cygwin does support Unix-style permissions, so I'm not following the rationale
for this change. Can you say more?
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: noah@leadboat.com, andrew@dunslane.net, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Skip some permissions checks on Cygwin
In-Reply-To: <20240624010311.0b.nmisch@google.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox