From: Álvaro Herrera <alvherre@kurilemu.de>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Michael Paquier <michael@paquier.xyz>
Cc: pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Move SQL-callable code related to multixacts into its own file
Date: Tue, 19 Aug 2025 12:31:14 +0200
Message-ID: <202508191031.5ipojyuaswzt@alvherre.pgsql> (raw)
In-Reply-To: <476683.1755560289@sss.pgh.pa.us>
On 2025-Aug-18, Tom Lane wrote:
> Michael Paquier <michael@paquier.xyz> writes:
> > On Mon, Aug 18, 2025 at 09:47:14AM -0400, Tom Lane wrote:
> >> Couldn't this have removed some #include-s from multixact.c?
>
> > Right. funcapi.h and fmgrprotos.h are direct dependencies, but
> > looking closer it is also possible to remove four more of them.
>
> Sounds good!
Hmm, don't you find strange that dbcommands.h is still included there?
I wondered about that and found out that we have get_database_name()
declared there. It sort-of makes sense, because it was originally done
by scanning pg_database, but since commit cb98e6fb8fd4 introduced a
syscache for it, we can have this routine in lsyscache.c/h instead,
where it feels more at home. It also seems more sensible to declare
get_database_oid() in pg_database.h. After these two changes, a lot of
files can stop including dbcommands.h. This seems a nice cleanup to me,
and passes headerscheck.
--
Álvaro Herrera PostgreSQL Developer — https://www.EnterpriseDB.com/Attachments:
0001-Avoid-including-commands-dbcommands.h-randomly.patch (text/x-diff, 0B) download
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: alvherre@kurilemu.de, tgl@sss.pgh.pa.us, michael@paquier.xyz, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Move SQL-callable code related to multixacts into its own file
In-Reply-To: <202508191031.5ipojyuaswzt@alvherre.pgsql>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox