From: Álvaro Herrera <alvherre@kurilemu.de>
To: Andres Freund <andres@anarazel.de>
Cc: Bertrand Drouvot <bertranddrouvot.pg@gmail.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Michael Paquier <michael@paquier.xyz>
Cc: pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Move SQL-callable code related to multixacts into its own file
Date: Tue, 19 Aug 2025 17:17:52 +0200
Message-ID: <202508191517.stvm64mnl5ss@alvherre.pgsql> (raw)
In-Reply-To: <rfewuot4kmvvb3zhuzxbbyj4z45susywiwd3s56axo66kggx3w@h2kaxj62ic36>
On 2025-Aug-19, Andres Freund wrote:
> On 2025-08-19 14:01:52 +0000, Bertrand Drouvot wrote:
> > That said, autoconf does not report the issue, and that's because test/modules
> > is missing in src/Makefile. Is there any reasons for that? If not, the attached
> > fix it.
>
> That can't be the reason - it's reached from src/test/Makefile
>
> > SUBDIRS = perl postmaster regress isolation modules authentication recovery subscription
Yeah, I'm not on board with making changes to the makefiles, because
AFAIR the current arrangement is purposefully what is is. I did
discover that my build script does "make install ; make -C contrib
install", which means src/test/modules is not built. But that's a local
fix for me.
--
Álvaro Herrera Breisgau, Deutschland — https://www.EnterpriseDB.com/
<inflex> really, I see PHP as like a strange amalgamation of C, Perl, Shell
<crab> inflex: you know that "amalgam" means "mixture with mercury",
more or less, right?
<crab> i.e., "deadly poison"
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: alvherre@kurilemu.de, andres@anarazel.de, bertranddrouvot.pg@gmail.com, tgl@sss.pgh.pa.us, michael@paquier.xyz, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Move SQL-callable code related to multixacts into its own file
In-Reply-To: <202508191517.stvm64mnl5ss@alvherre.pgsql>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox