pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Justin Pryzby <pryzby@telsasoft.com>
Cc: Christoph Berg <myon@debian.org>
Cc: Michael Paquier <michael@paquier.xyz>
Cc: pgsql-hackers@lists.postgresql.org
Subject: Re: pgsql: Add TAP test to automate the equivalent of check_guc
Date: Fri, 11 Feb 2022 10:41:27 -0500
Message-ID: <2027230.1644594087@sss.pgh.pa.us> (raw)
In-Reply-To: <20220211153549.GE31460@telsasoft.com>
References: <E1nHbaO-0000MF-RO@gemulon.postgresql.org>
	<YgYw25OXV5men8Fj@msg.df7cb.de>
	<2023925.1644591595@sss.pgh.pa.us>
	<20220211153549.GE31460@telsasoft.com>

Justin Pryzby <pryzby@telsasoft.com> writes:
> On Fri, Feb 11, 2022 at 09:59:55AM -0500, Tom Lane wrote:
>> This seems like a pretty bad idea even if it weren't failing outright.
>> We should be examining the version of the file that's in the source
>> tree; the one in the installation tree might have version-skew
>> problems, if you've not yet done "make install".

> My original way used the source tree, but Michael thought it would be an issue
> for "installcheck" where the config may not be available.

Yeah, you are at risk either way, but in practice nobody is going to be
running these TAP tests without a source tree.

> This is what I had written:
> FROM (SELECT regexp_split_to_table(pg_read_file('postgresql.conf'), '\n') AS ln) conf

That's not using the source tree either, but the copy in the
cluster-under-test.  I'd fear it to be unstable in the buildfarm, where
animals can append whatever they please to the config file being used by
tests.

			regards, tom lane





view thread (26+ messages)  latest in thread

Message-ID: <2027230.1644594087@sss.pgh.pa.us>
Permalink:  ../2027230.1644594087@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/2027230.1644594087@sss.pgh.pa.us

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: tgl@sss.pgh.pa.us, pryzby@telsasoft.com, myon@debian.org, michael@paquier.xyz, pgsql-hackers@lists.postgresql.org
  Subject: Re: pgsql: Add TAP test to automate the equivalent of check_guc
  In-Reply-To: <2027230.1644594087@sss.pgh.pa.us>
  References: <E1nHbaO-0000MF-RO@gemulon.postgresql.org> <YgYw25OXV5men8Fj@msg.df7cb.de> <2023925.1644591595@sss.pgh.pa.us> <20220211153549.GE31460@telsasoft.com> <2027230.1644594087@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox